Allow enabling the Performance panel in Fusebox

facebookexperimental · Apr 12, 2024 · d1814eb · d1814eb
1 parent 8cfd8f8
commit d1814eb
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 2 deletions.
diff --git a/front_end/core/root/Runtime.ts b/front_end/core/root/Runtime.ts
@@ -291,6 +291,7 @@ export enum RNExperimentName {
   REACT_NATIVE_SPECIFIC_UI = 'reactNativeSpecificUI',
   ENABLE_REACT_DEVTOOLS_PANEL = 'enableReactDevToolsPanel',
   JS_HEAP_PROFILER_ENABLE = 'jsHeapProfilerEnable',
+  ENABLE_PERFORMANCE_PANEL = 'enablePerformancePanel',
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again
@@ -326,6 +327,7 @@ export enum ExperimentName {
   JS_HEAP_PROFILER_ENABLE = RNExperimentName.JS_HEAP_PROFILER_ENABLE,
   REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
   ENABLE_REACT_DEVTOOLS_PANEL = RNExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
+  ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again

diff --git a/front_end/entrypoints/main/rn_experiments.ts b/front_end/entrypoints/main/rn_experiments.ts
@@ -235,3 +235,11 @@ RNExperiments.register({
   enabledByDefault: ({ isReactNativeEntryPoint }) => isReactNativeEntryPoint,
   configurable: false,
 });
+
+RNExperiments.register({
+  name: RNExperimentName.ENABLE_PERFORMANCE_PANEL,
+  title: 'Enable Performance panel',
+  unstable: true,
+  enabledByDefault: ({ isReactNativeEntryPoint }) => !isReactNativeEntryPoint,
+  configurable: ({ isReactNativeEntryPoint }) => isReactNativeEntryPoint,
+});
diff --git a/front_end/entrypoints/rn_fusebox/BUILD.gn b/front_end/entrypoints/rn_fusebox/BUILD.gn
@@ -32,6 +32,7 @@ devtools_entrypoint("entrypoint") {
     "../../panels/rn_welcome:meta",
     "../../panels/security:meta",
     "../../panels/sensors:meta",
+    "../../panels/timeline:meta",
     "../../panels/web_audio:meta",
     "../../panels/webauthn:meta",
     "../main:bundle",

diff --git a/front_end/entrypoints/rn_fusebox/rn_fusebox.ts b/front_end/entrypoints/rn_fusebox/rn_fusebox.ts
@@ -15,9 +15,9 @@ import '../inspector_main/inspector_main-meta.js';
 import '../../panels/issues/issues-meta.js';
 import '../../panels/mobile_throttling/mobile_throttling-meta.js';
 import '../../panels/network/network-meta.js';
-import '../../panels/js_profiler/js_profiler-meta.js';
 import '../../panels/react_devtools/react_devtools-meta.js';
 import '../../panels/rn_welcome/rn_welcome-meta.js';
+import '../../panels/timeline/timeline-meta.js';
 
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Host from '../../core/host/host.js';

diff --git a/front_end/panels/react_devtools/react_devtools-meta.ts b/front_end/panels/react_devtools/react_devtools-meta.ts
@@ -38,6 +38,7 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.title),
   commandPrompt: i18nLazyString(UIStrings.command),
   persistence: UI.ViewManager.ViewPersistence.PERMANENT,
+  order: 1000,
   async loadView() {
     const Module = await loadModule();
 

diff --git a/front_end/panels/timeline/timeline-meta.ts b/front_end/panels/timeline/timeline-meta.ts
@@ -125,6 +125,7 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.performance),
   commandPrompt: i18nLazyString(UIStrings.showPerformance),
   order: 50,
+  experiment: Root.Runtime.ExperimentName.ENABLE_PERFORMANCE_PANEL,
   async loadView() {
     const Timeline = await loadTimelineModule();
     return Timeline.TimelinePanel.TimelinePanel.instance();
@@ -136,7 +137,7 @@ UI.ViewManager.registerViewExtension({
   id: 'js_profiler',
   title: i18nLazyString(UIStrings.javascriptProfiler),
   commandPrompt: i18nLazyString(UIStrings.showJavascriptProfiler),
-  persistence: UI.ViewManager.ViewPersistence.CLOSEABLE,
+  persistence: UI.ViewManager.ViewPersistence.PERMANENT,
   order: 65,
   experiment: Root.Runtime.ExperimentName.JS_PROFILER_TEMP_ENABLE,
   async loadView() {