Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle many error predecessors in upon_error #543

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

ccotter
Copy link
Contributor

@ccotter ccotter commented Jun 25, 2023

upon_error did not handle predecessor senders that send 0 or more than 2 possible error types. This commit brings upon_error into conformance with the P2300 proposal's upon_error.

upon_error did not handle predecessor senders that send 0 or more than
2 possible error types. This commit brings upon_error into conformance
with the P2300 proposal's upon_error.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2023
@ccotter
Copy link
Contributor Author

ccotter commented Jun 25, 2023

I noticed this writing some tests for a reference capable finally(), and I assumed upon_error not supporting !=1 error predecessors was not intentional.

@ispeters ispeters merged commit 0ad461b into facebookexperimental:main Jun 25, 2023
@ispeters
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants