Merge pull request #433 from janondrusek/async-attach

`async_scope::attach` cleanup
facebookexperimental · Jul 7, 2022 · ebd6f9b · ebd6f9b
2 parents bd2388e + 445df0e
commit ebd6f9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/include/unifex/async_scope.hpp b/include/unifex/async_scope.hpp
@@ -977,7 +977,7 @@ struct async_scope {
   /**
    * Equivalent to attach(just_from((Fun&&)fun)).
    */
-  template(typename Scheduler, typename Fun)  //
+  template(typename Fun)  //
       (requires callable<Fun>)                //
       [[nodiscard]] auto attach_call(Fun&& fun) noexcept(
           noexcept(attach(just_from((Fun &&) fun)))) {

diff --git a/test/async_scope_test.cpp b/test/async_scope_test.cpp
@@ -479,6 +479,19 @@ TEST_F(async_scope_test, attach) {
   sync_wait(scope.cleanup());
 }
 
+TEST_F(async_scope_test, attach_connect) {
+  mock_receiver<void()> receiver;
+  auto sender = scope.attach(just());
+
+  // the outstanding operation is "transferred" from sender to operation
+  {
+    auto op = connect(std::move(sender), receiver);
+    // the operation is dropped w/o starting
+  }
+  // this will hang if record done on async_scope doesn't happen
+  sync_wait(scope.cleanup());
+}
+
 TEST_F(async_scope_test, attach_copy) {
   mock_receiver<void()> receiver;
   EXPECT_CALL(*receiver, set_value()).Times(2);