Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Document design decisions #1122

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Document design decisions #1122

merged 1 commit into from
Jan 5, 2022

Conversation

hermanventer
Copy link
Contributor

Description

Document design decisions and update tool chain. Update main.rs to initialize rustc logging if the RUSTC_LOG environmental variable is set. Treat mir::NullOp::Box as unreachable since the rust compiler no longer generates it
and it is about to be removed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #1122 (5f2aa56) into main (1aa4703) will decrease coverage by 0%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1122   +/-   ##
=====================================
- Coverage     77%     77%   -1%     
=====================================
  Files         23      23           
  Lines      16090   16087    -3     
=====================================
- Hits       12505   12494   -11     
- Misses      3585    3593    +8     
Impacted Files Coverage Δ
checker/src/block_visitor.rs 78% <0%> (+<1%) ⬆️
checker/src/abstract_value.rs 78% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa4703...5f2aa56. Read the comment docs.

@hermanventer hermanventer merged commit fc9be9d into main Jan 5, 2022
@hermanventer hermanventer deleted the decisions branch January 5, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants