Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Error Typo In ReadMe #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jahanzaibbaloch99
Copy link

I Just Got In error While Setting Up facebook Auth Button I Got Development Error But On Readme Doc on OnLoginFinished Callback It Was a typo which would have to be console.log("App has error ", error) instead it was console.log("App has error" , result.error) as it was Undefined

@facebook-github-bot
Copy link

Hi @jahanzaibbaloch99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants