This repository was archived by the owner on Apr 2, 2021. It is now read-only.
Update fbsdk to v5 on Android #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redcancode here are the changes needed for Android. |
redcancode
reviewed
Jun 14, 2019
android/build.gradle
Outdated
| @@ -4,7 +4,7 @@ def DEFAULT_COMPILE_SDK_VERSION = 28 | |||
| def DEFAULT_BUILD_TOOLS_VERSION = "28.0.3" | |||
| def DEFAULT_MIN_SDK_VERSION = 16 | |||
| def DEFAULT_TARGET_SDK_VERSION = 28 | |||
| def DEFAULT_FACEBOOK_SDK_VERSION = "4.38.1" | |||
| def DEFAULT_FACEBOOK_SDK_VERSION = "5.0.0" | |||
There was a problem hiding this comment.
@janicduplessis wouldn't it be better to set this to [5.0.0,5.1[ so we support 5.0.x? I think there shouldn't be any breaking changes in that range. i've set this to ~> 5.0.0 on iOS which is the same range for the same reason
janicduplessis
pushed a commit
that referenced
this pull request
Jun 14, 2019
There have been some breaking changes in the native FBSDK this year which prevents us from using the latest version. I've decided to help the problem and integrate the latest changes with this pull request. Currently I've integrated the iOS FBSDK changes. My app builds and runs and I was able to login and obtain an access token. I'm not finished with these integrations. Here are the list of things I want to do: - double check iOS FBSDK changes to make sure I've got everything - integrate Android FBSDK similarly - document all the changes I've made - test all the affected features After I've done with these items this PR should be ready for a real review and consideration to merge it and support the latest FBSDK on both platforms. It would be great if you could try this out and confirm that it works for you too. Everything should work on iOS. I've started my branch from the latest published version which is `0.9.0`. I did this on purpose because `master` is broken currently due to `RCTComponentEvent` still being unpublished. Your feedback would be greatly appreciated. 🙂 **[Update-2019-June-14]** This PR has been repurposed into integrating the latest FBSDK on iOS and JS only. The android part has been done in PR #546 Fixes #533
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LikeViewexpiredPermissionsanddataAccessExpirationTimeto tokensTest Plan:
Tested that the example app still works