restore react-native link functionality #349

koenpunt · 2017-07-01T12:38:59Z

react-native link doesn't support the new xml format yet, so for now we save it in the old format

ghost · 2017-07-13T22:23:04Z

Is there any workaround for this? I haven't been able to get even fbsdk v 0.5.0 to work with my new project.

paulftw · 2017-07-14T11:15:43Z

ios/ios.xcodeproj/project.pbxproj

+		1DD70E29001F47FB00000002 /* BUCK */ = {isa = PBXFileReference; explicitFileType = text.script.python; path = BUCK; sourceTree = SOURCE_ROOT; };
+		1DD70E29001F47FB00000003 /* BUCK */ = {isa = PBXFileReference; explicitFileType = text.script.python; path = BUCK; sourceTree = SOURCE_ROOT; };
+		1DD70E2900B6388300000000 /* libRNSDKShareKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; name = libRNSDKShareKit.a; path = lib.a; sourceTree = BUILT_PRODUCTS_DIR; };


path = lib.a on my machine means XCode will compile multiple different libraries into lib.a causing all sorts of troubles.
I have to manually set Product Name on each of the targets to stop that from happening.
Otherwise this is a change I'd really love to see merged into master.

paulftw · 2017-07-15T12:45:43Z

As a follow up to my review comment attaching the modifications I have on top of this PR. This addition makes pod install do the right job for new projects with Xcode 8.3.3.

--- project.pbxproj.1	2017-07-15 22:39:52.000000000 +1000
+++ project.pbxproj	2017-07-15 21:52:04.000000000 +1000
@@ -33,12 +33,12 @@
 		1DD70E29001F47FB00000001 /* BUCK */ = {isa = PBXFileReference; explicitFileType = text.script.python; path = BUCK; sourceTree = SOURCE_ROOT; };
 		1DD70E29001F47FB00000002 /* BUCK */ = {isa = PBXFileReference; explicitFileType = text.script.python; path = BUCK; sourceTree = SOURCE_ROOT; };
 		1DD70E29001F47FB00000003 /* BUCK */ = {isa = PBXFileReference; explicitFileType = text.script.python; path = BUCK; sourceTree = SOURCE_ROOT; };
-		1DD70E2900B6388300000000 /* libRNSDKShareKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; name = libRNSDKShareKit.a; path = lib.a; sourceTree = BUILT_PRODUCTS_DIR; };
-		1DD70E29031DBF3900000000 /* libRNSDKLoginKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; name = libRNSDKLoginKit.a; path = lib.a; sourceTree = BUILT_PRODUCTS_DIR; };
+		1DD70E2900B6388300000000 /* libRNSDKShareKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libRNSDKShareKit.a; sourceTree = BUILT_PRODUCTS_DIR; };
+		1DD70E29031DBF3900000000 /* libRNSDKLoginKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libRNSDKLoginKit.a; sourceTree = BUILT_PRODUCTS_DIR; };
 		1DD70E291591D1EC00000000 /* RNSDKShareKit-Release.xcconfig */ = {isa = PBXFileReference; explicitFileType = text.xcconfig; name = "RNSDKShareKit-Release.xcconfig"; path = "../../../../../buck-out/gen/Libraries/FBReactKit/js/react-native-fbsdk/ios/RNSDKShareKit-Release.xcconfig"; sourceTree = SOURCE_ROOT; };
 		1DD70E291A45CB9900000000 /* RCTFBSDKAppEvents.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = RCTFBSDKAppEvents.h; path = RCTFBSDK/core/RCTFBSDKAppEvents.h; sourceTree = SOURCE_ROOT; };
 		1DD70E291A45CB9E00000000 /* RCTFBSDKAppEvents.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = RCTFBSDKAppEvents.m; path = RCTFBSDK/core/RCTFBSDKAppEvents.m; sourceTree = SOURCE_ROOT; };
-		1DD70E291ECB10AC00000000 /* libRNSDK.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; name = libRNSDK.a; path = lib.a; sourceTree = BUILT_PRODUCTS_DIR; };
+		1DD70E291ECB10AC00000000 /* libRNSDK.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libRNSDK.a; sourceTree = BUILT_PRODUCTS_DIR; };
 		1DD70E2920FC65B100000000 /* RCTFBSDKAppInviteDialog.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = RCTFBSDKAppInviteDialog.h; path = RCTFBSDK/share/RCTFBSDKAppInviteDialog.h; sourceTree = SOURCE_ROOT; };
 		1DD70E2920FC65B600000000 /* RCTFBSDKAppInviteDialog.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = RCTFBSDKAppInviteDialog.m; path = RCTFBSDK/share/RCTFBSDKAppInviteDialog.m; sourceTree = SOURCE_ROOT; };
 		1DD70E29239FB7EC00000000 /* RCTConvert+FBSDKAccessToken.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = "RCTConvert+FBSDKAccessToken.h"; path = "RCTFBSDK/core/RCTConvert+FBSDKAccessToken.h"; sourceTree = SOURCE_ROOT; };
@@ -65,7 +65,7 @@
 		1DD70E29A1FB268A00000000 /* RNSDKShareKit-Profile.xcconfig */ = {isa = PBXFileReference; explicitFileType = text.xcconfig; name = "RNSDKShareKit-Profile.xcconfig"; path = "../../../../../buck-out/gen/Libraries/FBReactKit/js/react-native-fbsdk/ios/RNSDKShareKit-Profile.xcconfig"; sourceTree = SOURCE_ROOT; };
 		1DD70E29A8F8915900000000 /* RCTFBSDKLoginManager.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = RCTFBSDKLoginManager.h; path = RCTFBSDK/login/RCTFBSDKLoginManager.h; sourceTree = SOURCE_ROOT; };
 		1DD70E29A8F8915E00000000 /* RCTFBSDKLoginManager.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = RCTFBSDKLoginManager.m; path = RCTFBSDK/login/RCTFBSDKLoginManager.m; sourceTree = SOURCE_ROOT; };
-		1DD70E29AC0CD5F100000000 /* libRNSDKCoreKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; name = libRNSDKCoreKit.a; path = lib.a; sourceTree = BUILT_PRODUCTS_DIR; };
+		1DD70E29AC0CD5F100000000 /* libRNSDKCoreKit.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; path = libRNSDKCoreKit.a; sourceTree = BUILT_PRODUCTS_DIR; };
 		1DD70E29B8E1424100000000 /* RNSDK-Profile.xcconfig */ = {isa = PBXFileReference; explicitFileType = text.xcconfig; name = "RNSDK-Profile.xcconfig"; path = "../../../../../buck-out/gen/Libraries/FBReactKit/js/react-native-fbsdk/ios/RNSDK-Profile.xcconfig"; sourceTree = SOURCE_ROOT; };
 		1DD70E29BECE3BF400000000 /* RCTFBSDKAccessToken.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = RCTFBSDKAccessToken.h; path = RCTFBSDK/core/RCTFBSDKAccessToken.h; sourceTree = SOURCE_ROOT; };
 		1DD70E29BECE3BF900000000 /* RCTFBSDKAccessToken.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; name = RCTFBSDKAccessToken.m; path = RCTFBSDK/core/RCTFBSDKAccessToken.m; sourceTree = SOURCE_ROOT; };
@@ -378,6 +378,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E29C049749700000000 /* RNSDK-Debug.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDK;
 			};
 			name = Debug;
 		};
@@ -385,6 +386,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E29F349631C00000000 /* RNSDKCoreKit-Debug.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKCoreKit;
 			};
 			name = Debug;
 		};
@@ -392,6 +394,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E297A21682A00000000 /* RNSDKLoginKit-Debug.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKLoginKit;
 			};
 			name = Debug;
 		};
@@ -399,6 +402,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E2971F1D72000000000 /* RNSDKShareKit-Debug.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKShareKit;
 			};
 			name = Debug;
 		};
@@ -412,6 +416,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E29B8E1424100000000 /* RNSDK-Profile.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDK;
 			};
 			name = Profile;
 		};
@@ -419,6 +424,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E292B9FA38600000000 /* RNSDKCoreKit-Profile.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKCoreKit;
 			};
 			name = Profile;
 		};
@@ -426,6 +432,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E295C8A9D1400000000 /* RNSDKLoginKit-Profile.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKLoginKit;
 			};
 			name = Profile;
 		};
@@ -433,6 +440,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E29A1FB268A00000000 /* RNSDKShareKit-Profile.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKShareKit;
 			};
 			name = Profile;
 		};
@@ -446,6 +454,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E292C77EDA300000000 /* RNSDK-Release.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDK;
 			};
 			name = Release;
 		};
@@ -453,6 +462,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E299F364EE800000000 /* RNSDKCoreKit-Release.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKCoreKit;
 			};
 			name = Release;
 		};
@@ -460,6 +470,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E29D021487600000000 /* RNSDKLoginKit-Release.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKLoginKit;
 			};
 			name = Release;
 		};
@@ -467,6 +478,7 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1DD70E291591D1EC00000000 /* RNSDKShareKit-Release.xcconfig */;
 			buildSettings = {
+				PRODUCT_NAME = RNSDKShareKit;
 			};
 			name = Release;
 		};

koenpunt · 2017-07-16T10:37:24Z

@paulftw I don't know, I just opened the project in Xcode, en saved it again. I didn't change anything. You'll probably have the same issue with xml version?

matiasfha · 2017-07-23T20:51:45Z

Any news about this? Will this be merged back to master ? I'm having issues with the linking process of react-native-fbsdk 0.6.1 and the only way to make it work was manually updating the format of the file ios.xcodeproj .. Would be nice to get this fixed.

bernardakl · 2017-07-26T06:57:35Z

If I run react-native link react-native-fbsdk should I still do the manual setup of android and ios?

pukhalski · 2017-07-30T15:51:51Z

Could it be fixed somehow? It's been already a month since this PR...

raduflp · 2017-08-05T19:33:15Z

waiting for this as well :|

kevinmcalear · 2017-08-17T06:10:52Z

Please update this. It is also blocking me.

uniquarkD · 2017-08-29T05:44:01Z

Same here.

sospedra · 2017-08-29T12:45:00Z

Hello? Is anyone here? Do you realise this lib it's a requirement of your company in order to make money: Facebook's campaigns. And there's no alternative. The PR is done. And yet you still don't even answer :/

danscan · 2017-08-29T20:49:15Z

What action is required for this to be merged?

victorbadila · 2017-09-11T10:58:34Z

1 it's blocking us also. this should be either merged or commented on by the dev. it doesn't make sense to simply ignore the problem :)

aforty · 2017-09-13T19:52:16Z

This package is causing all sorts of problems and no one appears to be watching this project.

koenpunt · 2017-09-13T20:03:09Z

@aforty https://code.facebook.com/pages/876921332402685/open-source-code-of-conduct

Be friendly and patient.

aforty · 2017-09-13T20:42:11Z

With this branch I'm getting the following. Anyone have any ideas?

ld: library not found for -lRNSDKCoreKit
clang: error: linker command failed with exit code 1 (use -v to see invocation)

baba43 · 2017-09-18T09:20:48Z

It's true that we should stay friendly and patient, but it is very frustrating to have this kind of issues open for weeks. You ask for feedback, you get feedback (and a pull request) but this library is still not usable for many people out there, just because we can not get it to work.

Right now I'm figuring around how to get this library working without react-native link what seems very frustrating. If you can not provide a working solution for auto-linking you/we might need to have a little guide on how to link it manually, so that we can get this library working. Especially for people like me that come from Android and are no iOS experts.

For example what about this note:

Make sure that libRCTFBSDK.a shows up in the Link Binary with Libraries section of your build target's Build Phases.

I guess this is my problem, but how do I solve this problem if libRCTFBSDK is not showing up there (because linking is not possible). What should I add there?

koenpunt · 2017-09-18T11:11:43Z

As a workaround — which has been mentioned in an other issue too I believe — you can navigate to the library in the node_modules folder, open the xcodeproj file in Xcode, change the supported version to something and back (somewhere on the right) and save the file. Then it should be saved in the old plist format and react-native link should work again.

tzilist · 2017-09-20T00:05:42Z

To get this to work right now I had to do npm install -s react-native-fbsdk@0.6.0, which seemed to work.

namvox · 2017-09-20T02:21:57Z

@baba43 hope this post will give you a sense of how to do it manually
http://www.namvo.me/manual-setup-for-facebook-sdk-in-react-native/

ghost · 2017-09-20T04:28:04Z

@aforty I went into Xcode > Build Phases > Link Binary With Libraries and removed the libRNSDK*.a files listed there.

sospedra · 2017-09-20T07:23:35Z

Opened on 1st July... ridiculous
Is there any alternative?

lexor90 · 2017-10-02T09:24:12Z

@sospedra Why don't you simply install the one from https://github.com/koenpunt/react-native-fbsdk which is basically this pull request?

I solved it this way:

Remove the previous one:

react-native unlink react-native-fbsdk
npm r --save react-native-fbsdk

Install the fork which is working (this pull request):

npm i --save react-native-fbsdk@https://github.com/koenpunt/react-native-fbsdk#fix-project-for-link
react-native link react-native-fbsdk

Then just remember to follow the setup steps again (remember to link frameworks and to set up the framework search path correctly).

By doing this I'm able to run it without any need to tweak the module or xcode project files.

Edit: fix to checkout the proper fix branch

lepouya · 2017-10-05T01:15:17Z

Sorry about the delay in responses everyone

Why are you using ios.xcodeproj? You should only be needing RCTFBSDK

koenpunt · 2017-10-05T14:22:46Z

Why are you using ios.xcodeproj? You should only be needing RCTFBSDK

Not really using, but react-native link tries to parse the file, which doesn't work.

lepouya · 2017-10-05T17:58:24Z

Oh I see
I'll remove it from the repo then :) Thanks for the info

lepouya · 2017-10-09T21:31:55Z

File removed

sospedra · 2017-10-10T06:37:09Z

@lexor90 well, simply because this is the official one 💁

lexor90 · 2017-10-10T07:12:15Z

I know, but if the latest version is broken and there’s a fork to patch it, as long as you can verify what actually changed from the main version I think it can be a viable solution (especially when things are going to be merged probably). At least you don’t have to patch things locally meaning you will not be able to repeat the build process without repeating the same steps which is not really scalable.

Btw, I just wanted to give you a quick workaround.

sospedra · 2017-10-10T10:04:30Z

Agree. In the case of my company is just that this is -- at the end-- just a workaround. And we feel that an organization such as Facebook should provide a stable solution. As I said in previous comments, specially for a feature like this one from where Facebook actually profits a lot of money.

eurobob · 2017-10-12T02:56:40Z

@koenpunt why delete the branch? What's the current solution?

koenpunt · 2017-10-12T06:01:18Z

@eurobob #349 (comment)

restore react-native link functionality

34111cd

react-native link doesn't support the new xml format yet, so for now we save it in the old format

facebook-github-bot added CLA Signed GH Review: review-needed labels Jul 1, 2017

BATMAH69 mentioned this pull request Jul 5, 2017

react-native link issue after upgrade to react-native-fbsdk 0.6.1 facebook/react-native#14594

Closed

paulftw reviewed Jul 14, 2017

View reviewed changes

matiasfha mentioned this pull request Jul 23, 2017

Error when react-native link installing fbsdk facebook/react-native#11375

Closed

raduflp mentioned this pull request Aug 5, 2017

could not link react-native-fbsdk facebook/react-native#14670

Closed

kyoyadmoon added a commit to kyoyadmoon/react-native-fbsdk that referenced this pull request Sep 29, 2017

facebookarchive#349 fix ios linking

58a8335

richardgirges mentioned this pull request Sep 30, 2017

Error linking 0.6.1 facebook/react-native#16147

Closed

lepouya closed this Oct 9, 2017

koenpunt deleted the fix-project-for-link branch October 9, 2017 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

restore react-native link functionality #349

restore react-native link functionality #349

koenpunt commented Jul 1, 2017

ghost commented Jul 13, 2017

paulftw Jul 14, 2017

paulftw commented Jul 15, 2017

koenpunt commented Jul 16, 2017

matiasfha commented Jul 23, 2017

bernardakl commented Jul 26, 2017 •

edited

Loading

pukhalski commented Jul 30, 2017 •

edited

Loading

raduflp commented Aug 5, 2017

kevinmcalear commented Aug 17, 2017

uniquarkD commented Aug 29, 2017

sospedra commented Aug 29, 2017 •

edited

Loading

danscan commented Aug 29, 2017

victorbadila commented Sep 11, 2017

aforty commented Sep 13, 2017 •

edited

Loading

koenpunt commented Sep 13, 2017 •

edited

Loading

aforty commented Sep 13, 2017 •

edited

Loading

baba43 commented Sep 18, 2017 •

edited

Loading

koenpunt commented Sep 18, 2017

tzilist commented Sep 20, 2017

namvox commented Sep 20, 2017 •

edited

Loading

ghost commented Sep 20, 2017 •

edited by ghost

Loading

sospedra commented Sep 20, 2017

lexor90 commented Oct 2, 2017 •

edited

Loading

lepouya commented Oct 5, 2017 •

edited

Loading

koenpunt commented Oct 5, 2017 •

edited

Loading

lepouya commented Oct 5, 2017

lepouya commented Oct 9, 2017

sospedra commented Oct 10, 2017

lexor90 commented Oct 10, 2017

sospedra commented Oct 10, 2017

eurobob commented Oct 12, 2017

koenpunt commented Oct 12, 2017

restore react-native link functionality #349

restore react-native link functionality #349

Conversation

koenpunt commented Jul 1, 2017

ghost commented Jul 13, 2017

paulftw Jul 14, 2017

Choose a reason for hiding this comment

paulftw commented Jul 15, 2017

koenpunt commented Jul 16, 2017

matiasfha commented Jul 23, 2017

bernardakl commented Jul 26, 2017 • edited Loading

pukhalski commented Jul 30, 2017 • edited Loading

raduflp commented Aug 5, 2017

kevinmcalear commented Aug 17, 2017

uniquarkD commented Aug 29, 2017

sospedra commented Aug 29, 2017 • edited Loading

danscan commented Aug 29, 2017

victorbadila commented Sep 11, 2017

aforty commented Sep 13, 2017 • edited Loading

koenpunt commented Sep 13, 2017 • edited Loading

aforty commented Sep 13, 2017 • edited Loading

baba43 commented Sep 18, 2017 • edited Loading

koenpunt commented Sep 18, 2017

tzilist commented Sep 20, 2017

namvox commented Sep 20, 2017 • edited Loading

ghost commented Sep 20, 2017 • edited by ghost Loading

sospedra commented Sep 20, 2017

lexor90 commented Oct 2, 2017 • edited Loading

lepouya commented Oct 5, 2017 • edited Loading

koenpunt commented Oct 5, 2017 • edited Loading

lepouya commented Oct 5, 2017

lepouya commented Oct 9, 2017

sospedra commented Oct 10, 2017

lexor90 commented Oct 10, 2017

sospedra commented Oct 10, 2017

eurobob commented Oct 12, 2017

koenpunt commented Oct 12, 2017

bernardakl commented Jul 26, 2017 •

edited

Loading

pukhalski commented Jul 30, 2017 •

edited

Loading

sospedra commented Aug 29, 2017 •

edited

Loading

aforty commented Sep 13, 2017 •

edited

Loading

koenpunt commented Sep 13, 2017 •

edited

Loading

aforty commented Sep 13, 2017 •

edited

Loading

baba43 commented Sep 18, 2017 •

edited

Loading

namvox commented Sep 20, 2017 •

edited

Loading

ghost commented Sep 20, 2017 •

edited by ghost

Loading

lexor90 commented Oct 2, 2017 •

edited

Loading

lepouya commented Oct 5, 2017 •

edited

Loading

koenpunt commented Oct 5, 2017 •

edited

Loading