This repository was archived by the owner on Jan 13, 2022. It is now read-only.
[4.0][Fix] Fix stdClass error on FacebookRedirectLoginHelper #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2015
|
|
||
| // Graph v2.3 and greater return objects on the /oauth/access_token endpoint | ||
| $accessToken = null; | ||
| if ($response instanceof \stdClass && isset($response->access_token)) { |
There was a problem hiding this comment.
Maybe you can also use Go for consistency with the below property_exists($response, 'access_token'), maybe, I'm +0 about that hahaif statement
…ndling is kinda 💩
SammyK
force-pushed
the
4.0-access-token-response-fix
branch
from
6ab56c1 to
46d5de0
Compare
|
Thanks @yguedidi! Rebased. :) |
gfosco
added a commit
that referenced
this pull request
Apr 3, 2015
[4.0][Fix] Fix stdClass error on FacebookRedirectLoginHelper
|
god job keep it up! yes i updated code then after working... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Graph
v2.2and below, GET requests to the/oauth/access_tokenendpoint would return a query string in the body of the response:Starting in Graph
v2.3, the response body is json:Since v4.0 of the PHP SDK translated these two responses differently, it was causing errors for anyone using Graph v2.3 (#391, #392 and even here). This PR is an ugly hack to fix this without BC's. :)
Not sure if this response change will affect any other places in 4.0, but if we get any more issues about
stdClasserrors, you can bet it's due to the Graph response change.Version 4.1 of the SDK is unaffected.