Skip to content
This repository was archived by the owner on Jun 4, 2022. It is now read-only.

Conversation

@butjar
Copy link
Contributor

@butjar butjar commented Jun 10, 2020

https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

Add CMake cmake_minimum_required to CMakeLists.txt to silent
warning.

Description:
Trying to fix the OpenR github workflow, I see following warning from the fbzmq build:

CMake Warning (dev) in CMakeLists.txt:                                                                                                                                          
  No cmake_minimum_required command is present.  A line of code such as                                                                                                         
                                                                                                                                                                                
    cmake_minimum_required(VERSION 3.10)                                                                                                                                        
                                                                                                                                                                                
  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.   
                                                                          
-- Configuring incomplete, errors occurred!
See also "/usr/local/src/fbzmq/fbzmq/build/CMakeFiles/CMakeOutput.log".

The minimum version was taken from OpenR (https://github.com/facebook/openr/blob/master/CMakeLists.txt#L8).

https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

Add CMake `cmake_minimum_required` to `CMakeLists.txt` to silent
warning.
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangxu1121 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@xiangxu1121 merged this pull request in 7088b92.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants