This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Attachment Security Update #590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attachments have been moved out of a web accessible direcotry (
/var/www/fbctf/src/data/
) and now reside in/var/www/fbctf/attachments
.Attachment downloads are now handled by an endpoint in
/data
:attachment.php
.All links to attachments now refer to the correct
attachment.php
endpoint location.The
tar
command within the Attachment Import function now sets the mode to 600 at time of extraction.The Attachment Import functionality will no longer change or attempt to change permissions on the current or parent directories.
The Attachment Import functionality will no longer change permissions on any directories, though subdirectories are not supported.
Attachment filenames will no longer be altered, excluding the inclusion of the file hash.
The provision script has been updated to support the new Attachment directory location.
Attachment specific directives are no longer set in the Mult-Server Nginx configuration.
Attachment location information has been updated in the
.gitignore
configuration.