Skip to content
This repository was archived by the owner on Mar 3, 2020. It is now read-only.

Local Caching of Database and Cache Results #574

Closed
wants to merge 1 commit into from
Closed

Local Caching of Database and Cache Results #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/models/Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?hh // strict

class Cache {

private Map<string, mixed> $GLOBAL_CACHE = Map {};

public function __construct() {}

public function setCache(string $key, mixed $value): void {
$this->GLOBAL_CACHE->add(Pair {strval($key), $value});
}

public function getCache(string $key): mixed {
if ($this->GLOBAL_CACHE->contains($key)) {
return $this->GLOBAL_CACHE->get($key);
} else {
return false;
}
}

public function deleteCache(string $key): void {
if ($this->GLOBAL_CACHE->contains($key)) {
$this->GLOBAL_CACHE->remove($key);
}
}
}
73 changes: 63 additions & 10 deletions src/models/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?hh // strict

abstract class Model {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could either make Cache a singleton, or add a protected static Cache (or just the Map/dict and remove the Cache class) here

protected static Db $db = MUST_MODIFY;
protected static Memcached $mc = MUST_MODIFY;
protected static string $MC_KEY = MUST_MODIFY;
Expand Down Expand Up @@ -30,28 +31,80 @@ protected static function getMc(): Memcached {
}

protected static function setMCRecords(string $key, mixed $records): void {
$mc = self::getMc();
$mc->set(
static::$MC_KEY.static::$MC_KEYS->get($key),
$records,
static::$MC_EXPIRE,
$cache_key = static::$MC_KEY.static::$MC_KEYS->get($key);

/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
if (is_null($GLOBALS['GLOBAL_CACHE']) === true) {
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE'] = new Cache();
}

invariant(
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */ $GLOBALS['GLOBAL_CACHE'] instanceof Cache,
'GLOBAL_CACHE should of type Map and not null',
);

$mc = self::getMc();
$mc->set($cache_key, $records, static::$MC_EXPIRE);

/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE']->setCache($cache_key, $records);
}

protected static function getMCRecords(string $key): mixed {
$mc = self::getMc();
$mc_result = $mc->get(static::$MC_KEY.static::$MC_KEYS->get($key));
return $mc_result;
$cache_key = static::$MC_KEY.static::$MC_KEYS->get($key);

/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
if (is_null($GLOBALS['GLOBAL_CACHE']) === true) {
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE'] = new Cache();
}

invariant(
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */ $GLOBALS['GLOBAL_CACHE'] instanceof Cache,
'GLOBAL_CACHE should of type Map and not null',
);

/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$global_cache_result = $GLOBALS['GLOBAL_CACHE']->getCache($cache_key);
if ($global_cache_result !== false) {
return $global_cache_result;
} else {
$mc = self::getMc();
$mc_result = $mc->get($cache_key);
if ($mc_result !== false) {
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE']->setCache($cache_key, $mc_result);
}
return $mc_result;
}
}

public static function invalidateMCRecords(?string $key = null): void {
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
if (is_null($GLOBALS['GLOBAL_CACHE']) === true) {
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE'] = new Cache();
}

invariant(
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */ $GLOBALS['GLOBAL_CACHE'] instanceof Cache,
'GLOBAL_CACHE should of type Map and not null',
);

$mc = self::getMc();
if ($key === null) {
foreach (static::$MC_KEYS as $key_name => $mc_key) {
$mc->delete(static::$MC_KEY.static::$MC_KEYS->get($key_name));
$cache_key = static::$MC_KEY.static::$MC_KEYS->get($key_name);
$mc->delete($cache_key);
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE']->deleteCache($cache_key);
}
} else {
$mc->delete(static::$MC_KEY.static::$MC_KEYS->get($key));
$cache_key = static::$MC_KEY.static::$MC_KEYS->get($key);
$mc->delete($cache_key);
/* HH_IGNORE_ERROR[2050]: Usage of `global` was causing HH_ERROR 1002 and parsing errors, using the $GLOBALS superglobal instead. */
$GLOBALS['GLOBAL_CACHE']->deleteCache($cache_key);
}
}
}