Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Error Checking During Build Tests #452

Merged
merged 2 commits into from Feb 16, 2017
Merged

Error Checking During Build Tests #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d9a7f9
Error Checking During Build Tests
justinwray Feb 12, 2017
08cab4e
* Readded execute permissions to the script.
justinwray Feb 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions extra/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,11 @@ hhvm vendor/phpunit/phpunit/phpunit tests
echo "[+] Deleting test database"
mysql -u "$DB_USER" --password="$DB_PWD" -e "DROP DATABASE IF EXISTS $DB;"
mysql -u "$DB_USER" --password="$DB_PWD" -e "FLUSH PRIVILEGES;"

# In the future, we should use the hh_client exit status.
# Current there are some PHP built-ins not found in the hhi files upstream in HHVM.
echo "[+] Verifying HHVM Strict Compliance and Error Checking"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, nice hack :P

Can you list which PHP builtins it was complaining about for reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Looks like right now the only one we're using is: getimagesizefromstring().

if [[ $(hh_client $CODE_PATH | grep -vP "Unbound" | wc -l) != 0 ]]; then
hh_client $CODE_PATH
exit 1
fi