This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Add friendlier error for two adjacent elements #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As JSX is just sugar for function-calls, it does technically prevent valid uses. However, JSX is not intended as a substitute for function-calls so comparing the return-value of a JSX-tag never makes sense. If someone for some superweird reason would want that, they'll just have to assign it a variable first and compare that (or possibly flip the expression). 👍 |
|
Or parenthesize it, as I verified works in a test case. |
|
Ah yes ofc. |
| // element, we disallow it here in the parser in order to provide a | ||
| // better error message. (In the rare case that the less-than operator | ||
| // was intended, the left tag can be wrapped in parentheses.) | ||
| if (!origInXJSChild && lookahead.value === '<') { |
There was a problem hiding this comment.
s/lookahead.value === '<'/match('<')/
(this also checks that the type of the token is Punctuator)
Fixes facebook/react#1584. Test Plan: npm test
|
love it! |
jeffmo
pushed a commit
that referenced
this pull request
May 22, 2014
Add friendlier error for two adjacent elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes facebook/react#1584. We've had a handful of people confused about this recently so I think this would be nice to do if it doesn't conflict with any real uses that you can think of.
Test Plan: npm test
cc @jeffmo @syranide