This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Bump third_party/protobuf to v3.4.1 #1462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version fixes warnings when compiling on macOS. It is generally discouraged to use the bundled version of protobuf and rather use the system installed version. CMake, by default, will use the system installed version. When cross compiling Caffe2 (e.g. for mobile), it needs to use the bundled version of protobuf.
|
Verified it fixes the compile warnings: https://ci.pytorch.org/jenkins/job/caffe2-builds/job/caffe2-macos-build/4/console |
|
Hmm protobuf seems to be failing for Android. |
|
It has to do with some js_embed binary. Never heard of it. Hopefully it can just be disabled... |
|
Proper solution is probably something like protocolbuffers/protobuf#3878 but not sure when it will land... |
|
#1466 should do the bump and also address build temporarily. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version fixes warnings when compiling on macOS.
It is generally discouraged to use the bundled version of protobuf and
rather use the system installed version. CMake, by default, will use
the system installed version. When cross compiling Caffe2 (e.g. for
mobile), it needs to use the bundled version of protobuf.