-
Notifications
You must be signed in to change notification settings - Fork 158
Grammatical Mistakes #38
base: main
Are you sure you want to change the base?
Conversation
for seems redundant. builds, ->builds ,Release ->Space added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reading through this! Would you mind rolling back the {Debug,Release}
change?
@@ -3,7 +3,7 @@ | |||
[![Build Status](https://travis-ci.org/facebook/bistro.svg?branch=master)](https://travis-ci.org/facebook/bistro) | |||
|
|||
This README is a very abbreviated introduction to Bistro. Visit | |||
http://facebook.github.io/bistro for a more structured introduction, and for the docs. | |||
http://facebook.github.io/bistro for a more structured introduction, and the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a grammar fix, but a style preference. To me, having 2 "for" clauses is more clear. But if you feel passionate about this, do it your way.
various flavors of Linux and Mac OS. | ||
|
||
The binaries will be in `bistro/cmake/{Debug,Release}`. Available build | ||
The binaries will be in `bistro/cmake/{Debug, Release}`. Available build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not change this. The {foo,bar}
syntax has clear significance to anybody who uses a Bourne-style shell. Adding whitespace here changes the meaning. This is not a good fix, since the Release
directory does not, in fact, have a leading space.
@@ -47,10 +47,10 @@ very similar steps on most modern Linux distributions. | |||
|
|||
If you run into dependency problems, look at `bistro/cmake/setup.cmake` for | |||
a full list of Bistro's external dependencies (direct and indirect). We | |||
gratefully accept patches that improve Bistro's builds, or add support for | |||
gratefully accept patches that improve Bistro's builds or add support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch, thanks.
for seems redundant.
builds, ->builds
,Release ->Space added