-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added query by NSPredicate String capability. #124
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Our hope is to get something like MobileBy.iOSNSPredicate() added to Appium once it supports XCUITest. I've opened an issue here appium/appium-xcuitest-driver#27 FYI @Rafael-Chavez |
|
||
#pragma mark - Search by Predicate String | ||
+ (NSArray *)descendantsOfElement:(XCUIElement *)element withPredicateString:(NSString *)predicateString { | ||
XCUIElementQuery *query = [[element descendantsMatchingType:XCUIElementTypeAny] matchingPredicate:[NSPredicate predicateWithFormat:predicateString]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will not work with UIAutomation class names? Which we should remove anyway ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
@Rafael-Chavez Thanks for PR. Looks good to me. Please sign CLA & we can shit it :) |
@marekcirkos Already signed the CLA. |
@facebook-github-bot shipit |
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Try to de-flake safari tests in Travis
Summary: Closes facebookarchive/WebDriverAgent#124 Differential Revision: D3114535 Pulled By: marekcirkos fb-gh-sync-id: 5fc0b04a0b971e099c7978e553903d319dc21ba4 fbshipit-source-id: 5fc0b04a0b971e099c7978e553903d319dc21ba4
No description provided.