This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Unify boolean flag naming confention, getter spacing, and property attribute naming #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! Can you update the tests as well? ⌘U indicates that ASDisplayNodeAppearanceTests and ASDisplayNodeTests now fail to compile. |
|
Whoops! Will fix. Forgot about those. |
…tribute naming Summary: * Fixes #3 * Ordering: atomicity, then [optional] readonly, then value semantics (retain/copy/assign) * Removed redundant `readwrite` * No spaces between "getter = name" ("getter=name" instead) * Property method overrides renamed as well * self.isBlah, while technically not entirely correct, still resolves to [self blah], so left alone (@kimon had advice on this sort of naming issue last summer), and largely inconsequential Test Plan: * Compile and run
|
Also, if anything tries to do KVO on or set value for the following, the property name to observe mayhave changed: isSynchronous Since observing is usually done by string rather than symbolically, these deserve a quick look. |
secretiverhyme
added a commit
that referenced
this pull request
Jul 17, 2014
Unify boolean flag naming confention, getter spacing, and property attribute naming
|
builds & tests — ✔︎ |
nguyenhuy
pushed a commit
to nguyenhuy/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
readwriteTest Plan: