Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[Tests] Add launch image back for test host app - #3171

Merged
maicki merged 3 commits into
facebookarchive:masterfrom
maicki:MSAddLaunchImageForTestHost
Mar 13, 2017
Merged

[Tests] Add launch image back for test host app#3171
maicki merged 3 commits into
facebookarchive:masterfrom
maicki:MSAddLaunchImageForTestHost

Conversation

@maicki

@maicki maicki commented Mar 12, 2017

Copy link
Copy Markdown
Contributor

We lost the default image what causes Xcode warnings and the simulator running in the wrong dimension. Let's add it back.

@nguyenhuy nguyenhuy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not blocking, but I'd really appreciate if you could revert the changes here and here in the BUCK file to make use of the launch image.

@maicki

maicki commented Mar 13, 2017

Copy link
Copy Markdown
Contributor Author

@nguyenhuy Reverted this change. I didn't had to revert the other one for some reason this was still in there. Can you try it out again with BUCK.

@nguyenhuy

Copy link
Copy Markdown
Contributor

@maicki Thanks and don't worry, I added it myself LOL. Will merge when CI finishes.

@maicki
maicki merged commit dae3a72 into facebookarchive:master Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants