This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Clean up snapshot test cases - #3091
Merged
Adlai-Holler merged 2 commits intoFeb 27, 2017
Merged
Conversation
nguyenhuy
force-pushed
the
HNCleanupSnapshots
branch
from
February 27, 2017 15:36
b45f6ba to
f303172
Compare
nguyenhuy
commented
Feb 27, 2017
| ASTestDisplayNode *node = [[ASTestDisplayNode alloc] init]; | ||
| [node view]; | ||
| dispatch_semaphore_t sem = dispatch_semaphore_create(0); | ||
| [NSThread detachNewThreadWithBlock:^{ |
Contributor
Author
There was a problem hiding this comment.
This test case was failing on iOS 9 because detachNewThreadWithBlock is available since iOS 10.
- Drop 32bit snapshots - Update iOS 9 snapshots and move some others to the correct directory - Remove `setUp` overrides in subclasses of `ASLayoutSpecSnapshotTestCase` that set `recordMode` flag. Doing so in multiple places make it difficult to enable/dis able the flag for all layout spec test cases. It can always be overridden locally if need to. - Fix BUCK build
nguyenhuy
force-pushed
the
HNCleanupSnapshots
branch
from
February 27, 2017 15:57
7db3a88 to
b240426
Compare
Adlai-Holler
approved these changes
Feb 27, 2017
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Contributor
There was a problem hiding this comment.
Much better! Thanks for fixing my bungled BUCK work 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setUpoverrides in subclasses ofASLayoutSpecSnapshotTestCasethat setrecordModeflag. Doing so in multiple places make it difficult to enable/disable the flag for all layout spec test cases. It can always be overridden locally if need
to.
testThatOnDidLoadThrowsIfCalledOnLoadedOffMainofASDisplayNodeTests