This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASCollectionView/ASTableView] Support native item and section reloads #3066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
approved these changes
Feb 23, 2017
|
|
||
| // TODO if the change set includes solely section reloads that together are equivalent to reloadData (i.e reload the only section), | ||
| // do a reloadData here as an optimization. | ||
|
|
There was a problem hiding this comment.
Since reloadData is never animated, but section reloads may be, we probably won't want to build this optimization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3017, it's much easier to support native reloads now. Since updates are already broken down to inserts and deletes by
_ASHierarchyChangeSet,ASDataControllercan consume these inserts and deletes as is, and thenASCollectionView/ASTableViewforward the original changes toUICollectionView/UITableView. This resolves #469.Demo: