This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[Documentation] Improve readability of NS_OPTIONS in Swift - #2936
Merged
Conversation
Contributor
|
@hannahmbanana If we remove the comments directly from the enums will we loose the Xcode documentation in ObjC if you option-click on it within a source code? |
Contributor
|
@hannahmbanana Can you please also rebase your branch on top of master. It seems like you merged in master a couple of times instead of rebasing. |
Contributor
Author
|
@maicki - interesting point about losing the option-click documentation. Shall we abandon this idea then? |
Contributor
|
I think we should only have the |
hannahmbanana
force-pushed
the
HTSwiftReadability
branch
from
January 26, 2017 22:45
ccb8968 to
57b2737
Compare
Contributor
|
Nice improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.