This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASDataController] Simplify data controller - #2923
Merged
Adlai-Holler merged 5 commits intoJan 25, 2017
Merged
Conversation
nguyenhuy
force-pushed
the
SimplifyDataController
branch
from
January 24, 2017 02:56
c4e68a1 to
bb95cd1
Compare
nguyenhuy
changed the title
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Contributor
There was a problem hiding this comment.
This is a huge architectural step forward!
|
|
||
| - (void)endUpdatesAnimated:(BOOL)animated ASDISPLAYNODE_DEPRECATED_MSG("Use -performBatchUpdates:completion: instead."); | ||
|
|
||
| - (void)endUpdatesAnimated:(BOOL)animated completion:(nullable void (^)(BOOL))completion ASDISPLAYNODE_DEPRECATED_MSG("Use -performBatchUpdates:completion: instead."); |
Contributor
There was a problem hiding this comment.
Unfortunately Pinterest still relies on this API so we can't remove it just yet.
Contributor
Author
There was a problem hiding this comment.
@Adlai-Holler: I was hoping to reduce code complexity in ASCollectionView by removing these methods. I added them back, turns out it's not that bad.
nguyenhuy
force-pushed
the
SimplifyDataController
branch
from
January 24, 2017 21:03
5773f43 to
135e4d9
Compare
Adlai-Holler
approved these changes
Jan 25, 2017
Adlai-Holler
left a comment
Adlai-Holler
left a comment
Contributor
There was a problem hiding this comment.
Beautiful, I've reviewed the code and tested with Pinterest for a while, so it's landing time! The first of many big steps forward for ASDataController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Adlai-Holler: Appreciate your review here.
Closes #2916.