This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Annotate -didLoad with an attribute (if supported) that will flag missing didLoad calls #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing didLoad calls
|
Actually, getting some different bizarre behavior that may not be related to this that led to the crash after all. This might be convenient, but doesn't fix the odd crash I'm getting. Looking into it. |
|
Weird crash is unrelated and reported as #29, but this is still probably useful so people remember to call |
|
I like it — let's round up the other methods that require super and include them too! cc @acoomans |
secretiverhyme
force-pushed
the
master
branch
2 times, most recently
from
008ea34
to
9a8c2d0
Compare
appleguy
added a commit
that referenced
this pull request
Oct 15, 2014
Annotate -didLoad with an attribute (if supported) that will flag missing didLoad calls
|
Thanks for implementing this @toulouse ! I'll make a new task to go back and add annotations for other methods this would be useful for. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting some bizarre memory deallocation calls on a trivial demo. In building a repro case, I realized it was because I didn't call [super didLoad] in my node subclass (there were no problems after I did this). It'd be nice to get a warning for this, so I added in
ASDISPLAYNODE_REQUIRES_SUPERinASBaseDefines.hand applied it to didLoad.