This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASCollectionView] Add Method to Wait for Updates During Next Layout Pass #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Adlai-Holler
changed the title
Adlai-Holler
force-pushed
the
AHWaitForInitialData
branch
from
863d006 to
0a04786
Compare
appleguy
reviewed
Sep 27, 2016
AsyncDisplayKit/ASCollectionView.mm
Outdated
| - (void)waitForUpdatesDuringNextLayoutPass | ||
| { | ||
| ASDisplayNodeAssertMainThread(); | ||
| [self setNeedsLayout]; |
There was a problem hiding this comment.
@Adlai-Holler should this actually set a new layout pass as being needed? The name doesn't currently imply that.
There was a problem hiding this comment.
You're absolutely right – that was a holdover from some previous implementation I believe. Removed.
Adlai-Holler
force-pushed
the
AHWaitForInitialData
branch
from
0a04786 to
19312dc
Compare
|
Ready for next review @maicki @appleguy @garrettmoon |
|
LGTM |
garrettmoon
reviewed
Sep 28, 2016
| * Tell the collection view that, during the next layoutSubviews pass, it should block the | ||
| * main thread and wait for all items to be up-to-date. | ||
| * | ||
| * @discussion This is useful when you want to ensure that the user never sees an empty |
There was a problem hiding this comment.
Can we add a @warning in the waitUntilAllUpdatesAreCommitted method indicating they might want to use this method instead?
|
This will be changed so much in light of the 2.0 ASCollectionView/ASTableView -> Node diff that it may as well be closed. Sayonara. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the normal flow, the initial data is loaded during the first layout pass. This adds a flag for the user to tell us "when the next layout pass happens, block the main thread until the data is up-to-date".
waitUntilAllUpdatesAreCommittedfails if the initial reload hasn't been performed yet.reloadDataonly be callable on the main thread for ASCollectionView. It's a pretty small API change, since all of our other editing operations are already required to be on the main thread. It was already required for table view.Resolves #1584 and essentially #1642 also.
Ready for review!