This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASTableView] Go Straight to Super for Requerying Heights #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
LGTM |
|
@Adlai-Holler What's the status on this one? Should we rebase and merge? |
|
It's not ready to merge – it's causing problems but I haven't investigated yet Sent from my iPhone
|
|
This is more trouble than it's worth right now. #2248 fixes the only issue that has actually been observed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to involve the data controller, range controller, or data source here. We just want UITableView to ask us for our row heights again.