This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASTextNode] Fix wrong truncation after constrained size changes #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maicki
changed the title
…are changing Throw away the all subcomponents to create them with the new constrained size new as well as let the truncater do it's job again for the new constrained size. This is necessary as after a truncation did happen the context would use the truncated string and not the original string to truncate based on the new constrained size
|
LGTM! It's sad that we have to throw away these components. On the other hand, it's necessary to avoid nasty bugs that are hard to catch, and constrained size is not changed that frequent anyway. |
|
Love this, merge it at will! |
| @@ -123,14 +123,14 @@ - (void)setConstrainedSize:(CGSize)constrainedSize | |||
| if (!CGSizeEqualToSize(constrainedSize, _constrainedSize)) { | |||
| _sizeIsCalculated = NO; | |||
There was a problem hiding this comment.
We should also reset _calculatedSize here, to CGSizeZero I guess.
Arthraim
pushed a commit
to iftechio/AsyncDisplayKit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw away the all subcomponents to create them with the new constrained size new as well as let the truncater do it's job again for the new constrained size. This is necessary as after a truncation did happen the context would use the truncated string and not the original string to truncate based on the new constrained size
This should fix #1841 and finally #1865