[ASDisplayNode] Fix setNeedsLayout triggered from subnode will not trigger relayout

[maicki]

Current if [ASDisplayNode invalidateCalculatedLayout] and [ASDisplayNode setNeedsLayout] called in a subclass (see[ASButtonNode setTitle:]) the call actually does not trigger any relayout. It does not even bubble up the tree as it returns early in [ASDisplayNode __setNeedsDisplay]

After talking with @nguyenhuy about the initial intention why we are returning early there we found a better way for it.

This should resolve: #1865

@nguyenhuy @levi @appleguy Can I get a look over please

[nguyenhuy]

@maicki: LGTM. Thanks for fixing this!

For the record, we want to return early only if there is no constrained size available for the coming relayout. The current check for this condition ([layout hasDirtyLayout], or !_flags.isMeasured previously) is too strict because it causes a constrained size in a dirty layout to be ignored, even though that size can be reused. @maicki and I agreed that the condition proposed in this PR is a better one.

[levi]

👍👍👍

[suomalainen9890]

@maicki : It does work now but not 100%. Sometimes the old bug happens, probability is around 1/20.

[maicki]

@suomalainen9890 We are aware of it that this is not the full fix and @nguyenhuy will look into that probably later today / this week and follow up. Thanks for testing though!