This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[Example] Resolved ASTextNode bugs (test app to reproduce issues, do regression testing) #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleguy
changed the title
| return node; | ||
|
|
||
| case 2: | ||
| node.maximumNumberOfLines = 3; |
There was a problem hiding this comment.
Can you remove these additional cases for now? They're easy to add back in as we implement more.
|
@hannahmbanana Thanks! This is pretty clean. Certainly more we can do to upgrade it over time, but I'm glad we have this project in as a base to continue improving test coverage (and even during-development example app suites) for ASTextNode. Later, we should add examples from multiple writing scripts, etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.