This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Fix unit tests in ASTextNodeWordKernerTests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were comparing CGFloats with ==. XCTAssertTrue has been replaced by XCTAssertEqualWithAccuracy
|
Indeed ! |
secretiverhyme
added a commit
that referenced
this pull request
Sep 5, 2014
Use XCTAssertEqualWithAccuracy in ASTextNodeWordKernerTests.
|
Merged. Thanks @raphaelmor! |
Adlai-Holler
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Add Danger * Move danger up * Remove slather for now * Have danger failures in log * Add print out of API token for debugging * Make verbose * Make verbose for real * Try this * Revert "Try this" This reverts commit 3bfc16382122ee1200ab82f8cbc76b967653606f. * Try another thing * Get rid of logging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were comparing CGFloats with ==. XCTAssertTrue has been replaced
by XCTAssertEqualWithAccuracy