Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

[ASVideoNode] Re-enabling HLS video constructed from URL #1748

Closed
wants to merge 306 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
306 commits
Select commit Hold shift + click to select a range
383667f
[ASThrashTesting] Rocking and rolling!
Jun 23, 2016
3ca9577
[ASThrashTesting] Some cleanup
Jun 23, 2016
bd7f90f
[ASThrashTesting] Remove unneeded clang diagnostics
Jun 23, 2016
9fc3ec9
[ASThrashTesting] Numbers so magic
Jun 23, 2016
12336de
[ASThrashTesting] Array is immutable
Jun 23, 2016
7175afb
Merge pull request #1790 from gazreese/ASVideoNode-delegate-superclass
maicki Jun 23, 2016
95b0347
Merge pull request #1785 from facebook/AHWillDisplayCellDeprecate
maicki Jun 23, 2016
4f61b6e
Merge pull request #1777 from maicki/StructsForDrawingParameter
maicki Jun 23, 2016
57310a6
Merge pull request #1802 from facebook/AHThrashTesting
Jun 23, 2016
54e29d2
[Carthage] fix travis build error (#1804)
Jun 23, 2016
2375e31
Merge pull request #1721 from rcancro/layoutSpec
maicki Jun 23, 2016
f0bfa24
Merge pull request #1766 from hannahmbanana/collectionLayout
maicki Jun 23, 2016
d850057
[Travis CI] move carthageBuildTest to examples_extra to avoid Travis …
Jun 23, 2016
997d37d
[ASEnvironment] Don't relayout as a result of clearing a traitCollect…
rcancro Jun 24, 2016
457e080
[ASDataController] Remove asyncDataFetching Option, Cleanup (#1794)
Jun 24, 2016
9349abb
Merge branch 'master' of https://github.com/facebook/AsyncDisplayKit …
gareth-chillingo Jun 24, 2016
77f2423
[Documentation] Add a comment why we prefer -indexPathForItem:inSection:
Jun 24, 2016
71d9f64
Carry over first-pass change set improvements
Jun 23, 2016
35056f7
[ASDataController] Improve update handling
Jun 23, 2016
9c70cec
Improve update handling more
Jun 23, 2016
681876b
Fix more issues with data integrity
Jun 24, 2016
d8d2524
One more critical update integrity fix
Jun 24, 2016
5d72f2f
Enable the thrash testing
Jun 24, 2016
84e8b26
[ASDataController] Combine isolated reloads into a batch
Jun 24, 2016
304f8f6
[ASHierarchyChangeSet] Clean up and add documentation
Jun 24, 2016
27dc52c
[ASHierarchyChangeSet] Document reload-splitting behavior
Jun 24, 2016
0a525a3
[ASFlowLayoutController] Fix enumeration bug in ASFlowLayoutController
Jun 24, 2016
211dcdf
[_ASHierarchyChangeSet] Remove unused new method
Jun 24, 2016
0a354f8
[ASDataController] Remove implementation for unused hooks
Jun 24, 2016
3fb0e18
[ASTextNode] Further locking improvements for ASTextNode (#1813)
maicki Jun 24, 2016
e4abe89
[ASEditableTextNode] Support UITextInputTraits pass-through methods (…
Jun 24, 2016
42a1227
Merge remote-tracking branch 'facebook/master'
hannahmbanana Jun 25, 2016
2e4b1ea
[ASCellNode] Fix selection / highlight implementation
hannahmbanana Jun 25, 2016
7ddef95
fix compile errors
hannahmbanana Jun 25, 2016
f71e207
Remove old website files from master branch (#1817)
Jun 27, 2016
ae87717
Revert "Remove old website folder from master branch" (#1818)
appleguy Jun 27, 2016
56a5343
Collect subnodes passing the test, not the node with the subnodes pas…
Jun 27, 2016
cc74fb0
Prove the change gets the correct nodes with a pair of tests.
Jun 27, 2016
db04f4b
[ASTableView] Add constrainedSizeForRowAtIndexPath: to control row he…
Jun 27, 2016
d55621c
[ASCollectionView] Tuning parameters not set
gareth-chillingo Jun 27, 2016
4091d70
Add `conformsToProtocol:` to ASDelegateProxy
maicki Jun 27, 2016
d69dd88
Exposing `supplementaryNodeOfKind:atIndexPath:` in the `ASCollectionV…
Jun 20, 2016
488ded2
`ASCollectionDataController`s `supplementaryNodeOfKind:atIndexPath:` …
Jun 20, 2016
1c10333
`ASCollectionView` docs for `-supplementaryNodeOfKind:atIndexPath:` +…
Jun 21, 2016
9c13018
Updates exposed method signature and docs for what is now `-supplemen…
Jun 22, 2016
f7fa90a
[Project] Publicize ASPINRemoteImageDownloader.h
Jun 27, 2016
20edc81
Update build.sh file
Jun 27, 2016
e0fc55e
Jenkins build test
Jun 27, 2016
c10497e
Jenkins build test 2
Jun 28, 2016
ceff3e8
Jenkins build test 3
Jun 28, 2016
0414cf7
Jenkins build test 4
Jun 28, 2016
db9826c
Add a space for Jenkins testing
Jun 28, 2016
d82e1ce
Merge pull request #1812 from facebook/AHUpdateIntegrity
Jun 28, 2016
1d35624
[ASVideoNode] Ensure that observer methods don't observer all other A…
gareth-chillingo Jun 28, 2016
45ef911
[ASTextNode] Release Lock Sooner in -setAttributedText: (#1828)
Jun 29, 2016
284160b
Merge pull request #1821 from maicki/MSAddConformsToProtocolToProxy
Jun 29, 2016
f0e96cc
Change @import to #import
maicki Jun 30, 2016
5f7cdbd
Handle placeholder layer creation in case the size of the node change…
maicki Jun 21, 2016
d1b4e07
Add support for 'preferredFrameSize' to ASButtonNode
maicki Jun 23, 2016
53f22da
Code style improvements
maicki Jun 23, 2016
27b99cf
Make NSIndexSet helpers framework-visible
Jun 30, 2016
04b0ace
Merge pull request #1835 from facebook/AHMakeIndexSetHelpersFramework…
Jun 30, 2016
e5b5bba
Merge pull request #1832 from maicki/MSFixImport
Jun 30, 2016
8804342
Don't propagate trait collections to cells if the node is not loaded …
maicki Jul 1, 2016
8c3025b
[ASDisplayNode] added asyncTraitCollectionDidChange method (#1831)
rcancro Jul 1, 2016
09a344b
[ASVideoPlayerNode] Expose the placeholder image for the video player…
gareth-chillingo Jul 1, 2016
0a5f03e
Merge master into ASVideoPlayerNode-placeholder-image
gareth-chillingo Jul 1, 2016
b1ceab7
Add nodeForPageAtIndex: to header and clean up doc
levi Jul 1, 2016
53bc126
Add implementation of nodeForPageAtIndex:
levi Jul 1, 2016
ebaa2c1
Remove aggregate CGRect initializers in ASDataController
Jul 1, 2016
d80a443
Merge pull request #1840 from facebook/AHRemoveAggregateInitializer
Jul 1, 2016
d8efa54
Merge pull request #1806 from maicki/MSAddASButtonNodePreferredFrameSize
Jul 1, 2016
96fb5b3
Merge pull request #1786 from maicki/FixPlaceholderIsNotAppearing
Jul 1, 2016
5dcc7e9
Merge pull request #1823 from facebook/AHExposePINDownloader
Jul 1, 2016
3814f42
Merge pull request #1838 from levi/patch-18
Jul 1, 2016
988098b
Merge pull request #1837 from gazreese/ASVideoPlayerNode-placeholder-…
Jul 1, 2016
a77a6ea
Merge pull request #1820 from gazreese/ASCollectionView-tuning-parame…
Jul 1, 2016
9501299
Use flags to cache instead of instance variables for caching respond …
maicki Jun 24, 2016
a204f30
Merge remote-tracking branch 'facebook/master'
Jul 1, 2016
d7fde61
update from master/
Jul 1, 2016
01fed69
Adds trampoline for inserting and deletion of nodes
maicki Jun 28, 2016
d2d8b0a
[ASDisplayNode] Adjust behavior of -removeFromSupernode to ensure "ro…
appleguy Jul 2, 2016
f4ccb93
Merge pull request #1788 from gazreese/ASVideoNode-overwrittenplaceho…
Jul 2, 2016
4d67b44
Merge pull request #1808 from maicki/MSCacheSelectorFlagsNetworkImage…
Jul 2, 2016
5d7f3b4
Merge pull request #1819 from kielgillard/master
Jul 2, 2016
9be2f1d
Prevent calling endUpdatesAnimated:completion: in an unbalanced way
maicki Jun 29, 2016
d8c0253
Merge pull request #1830 from maicki/FixUnbalancedEndBatchUpdatesCalls
Jul 2, 2016
52a34db
Add pending state for range mode in ASTableNode and ASCollectionNode
maicki Jun 30, 2016
3080ee3
Revert "update from master/"
Jul 2, 2016
d8b3878
Merge remote-tracking branch 'facebook/master'
Jul 2, 2016
61d7c09
Merge branch 'master' into selectionBug
Jul 2, 2016
bf6fbd1
Address first comments
maicki Jul 3, 2016
9de014f
Change applySubnodeTransition to startTransition
maicki Jul 3, 2016
c20f452
Remove check for [UIDevice systemVersion] check if running on iOS 7 (…
maicki Jul 4, 2016
3763df1
[Example] Resolved ASTextNode bugs (test app to reproduce issues, do …
Jul 4, 2016
682ddcf
[AsyncDisplayKit+Utilities.h] Convenience methods for creating resiza…
Jul 4, 2016
b9b0023
[ASVideoNode] Only seek to beginning when auto repeating
gareth-chillingo Jul 5, 2016
3994f20
[ASCellNode] Final revisions to behavior of setSelected: & setHighlig…
Jul 6, 2016
edd656f
update cocoapod stats
Jul 6, 2016
f6d30b6
add comments to deprecated getter methods, remove extraneous if state…
Jul 6, 2016
9eed544
Copy header files using the Copy Files phase rather than the Headers …
Jul 6, 2016
f7b7bce
* Make the "Life Without Cocoapods" sample build and run.
Jul 6, 2016
c62a4d3
[ASCollectionView] Greatly Improve Cell Node Resizing (#1853)
Jul 6, 2016
6a15ab6
* Tidy the header imports, forward declaring classes and protocols wh…
Jul 7, 2016
762e983
Make ASViewController sample build and run.
Jul 7, 2016
94ca363
Add return type to the shouldNotAnimateBlock
maicki Jul 7, 2016
637c4f3
[ASTraitCollection] Remove traitCollectionContext from ASTraitCollect…
rcancro Jul 7, 2016
ec4b666
update ASTraitCollection header
rcancro Jul 7, 2016
3512cf4
assert we are on the main thread before accessing view.
rcancro Jul 7, 2016
54ee62f
[ASCollectionView] Add a strong pointer from ASCollectionView -> laye…
Jul 7, 2016
7314a18
rename containerWindowSize to containerSize
rcancro Jul 7, 2016
ff0e284
fixed formatting
rcancro Jul 7, 2016
8081123
Fix visibility assert on iOS 7
garrettmoon Jul 6, 2016
b79641d
Use indexOfObjectIdenticalTo since we only care if the pointers are e…
garrettmoon Jul 7, 2016
8ea1a2a
Merge pull request #1854 from garrettmoon/fixiOS7VisibilityDepth
Jul 7, 2016
332ab23
Merge pull request #1858 from maicki/MSFixBlockDeclaration
Jul 7, 2016
8e1c8ac
Merge pull request #1861 from facebook/AHCollectionViewLayerRetaining
Jul 8, 2016
312de1a
Make sure range controller listens to node display notifications if a…
nguyenhuy Jul 7, 2016
9154fbb
Merge pull request #1864 from nguyenhuy/range_controller
Jul 8, 2016
33620b9
Merge pull request #1834 from maicki/MSVisibilityTriggeringViewCreation
Jul 8, 2016
f25e0f0
Fix Xcode 8 errors
maicki Jul 8, 2016
82233af
Merge pull request #1860 from rcancro/upstream_remove_context
Jul 8, 2016
a0aad46
[ASDataController] Temporarily disable some troublesome assertions
Jul 8, 2016
02a41f4
Move setting the tuning parameters to the range controller in ASTable…
maicki Jul 8, 2016
78ef8cd
Merge pull request #1869 from facebook/AHDisableTroublesomeAssertions
Jul 8, 2016
b3d6736
Merge pull request #1867 from maicki/MSFixXcode8Errors
Jul 8, 2016
b1626b0
Merge pull request #1791 from colinmcardell/ASCollectionDataControlle…
Jul 8, 2016
057c484
Fix Modal presented ASViewController don't rotate on iOS 8.3
maicki Jun 25, 2016
33e093b
Check if a superview is present before calculating the legacy constra…
maicki Jul 8, 2016
d1c84a1
Merge pull request #1814 from maicki/MSFixiOS8ModalRotationAdjustment
Jul 8, 2016
ac9549e
Merge pull request #1870 from maicki/MSTuningParametersInTableView
Jul 8, 2016
b2810ed
Move dealloc method from ASImageNode+AnimatedImage category to ASImag…
maicki Jul 8, 2016
fe61c3e
[ASEnvironmentTraitCollection] Fixed bug where containerSize wasn't b…
rcancro Jul 8, 2016
7995b6e
Merge pull request #1872 from rcancro/containerSizeBug_upstream
Jul 8, 2016
0906958
Merge pull request #1871 from maicki/MSMoveDeallocASImgeNode
Jul 8, 2016
a2d4dc5
Merge pull request #1839 from maicki/MSAsyncMeasure
Jul 8, 2016
0f589d7
Merge pull request #1847 from gazreese/ASVideoNode-no-auto-seek
Jul 8, 2016
38fab7c
Merge pull request #1816 from hannahmbanana/selectionBug
Jul 8, 2016
6238e5e
[ASTextNode] Fix text node truncation (#1863)
maicki Jul 9, 2016
f0ff9c1
Merge branch 'master' of git://github.com/kielgillard/AsyncDisplayKit…
appleguy Jul 9, 2016
d8d20fd
Merge branch 'kielgillard-master'
appleguy Jul 9, 2016
01ba38d
[ASVideoPlayerNode] Ensure activity indicator view is transparent (#1…
gazreese Jul 9, 2016
48311ae
[Build] Fix build issue caused by an #import change.
appleguy Jul 9, 2016
d646d3c
Use textStorageCreationBlock for resetting the text storage (#1874)
maicki Jul 9, 2016
e7e2672
Move imageLock in braces for getting drawing parameters (#1876)
maicki Jul 10, 2016
3b2af7e
[Build] Remove Unused Imports across all of AsyncDisplayKit. This us…
appleguy Jul 10, 2016
dc12042
[ASDisplayNode] Do not start measurement for a transition if we have …
appleguy Jul 10, 2016
131dd25
[ASNetworkImageNode] Check that data is not nil before loading the an…
flovouin Jul 10, 2016
f39c2ce
[ASTextNode, ASImageNode, ASVideoNode] Use ASDisplayNode base class l…
Jul 10, 2016
3efd01a
[ASCollectionDataController] Repopulate deleted supplementary nodes i…
erichoracek Jul 10, 2016
1d07759
[ASDisplayNode+AsyncDisplay] Add locking for _flags (although write-o…
appleguy Jul 10, 2016
ff7a586
[ASVideoPlayerNode] Use ASDisplayNode base class lock for subclass pr…
Jul 10, 2016
d83f319
Revert "Use textStorageCreationBlock for resetting the text storage (…
appleguy Jul 10, 2016
bf9c142
Revert "[ASTextNode] Fix text node truncation (#1863)"
appleguy Jul 10, 2016
1044799
[ASMapNode] use ASDisplayNode base class lock (#1879)
Jul 10, 2016
2e65339
[ASVideoNode, ASVideoPlayerNode] Add video composition and audio mix …
flovouin Jul 10, 2016
5856bd3
[Cocoapods] Update podspec with 1.9.81
Jul 10, 2016
a9e3eac
[ASCellNode] Add gating for -convertRect: call upon invisibility noti…
appleguy Jul 10, 2016
b9c9e6b
Update README.md
Jul 11, 2016
bd6e85e
Remove old (original website) files from repository
Jul 11, 2016
cf01017
Update .gitignore
Jul 11, 2016
1d93dbc
Add files via upload
Jul 11, 2016
2317e17
Remove UIKit call from -init!1
Jul 11, 2016
a8f01fb
Merge pull request #1887 from facebook/fixASDKgram
Jul 11, 2016
012c927
[ASLayout] Small optimization to eliminate one method call in an extr…
appleguy Jul 11, 2016
69ca67b
Code cleaning and fixes based on code review.
george-gw Jul 11, 2016
57ece0f
[ASLayoutSpec] Bug where finalLayoutable was not being called for set…
rcancro Jul 11, 2016
0696ea8
fixed trait example
rcancro Jul 11, 2016
f8e294b
fix image paths in example_extra/Multiplex
eJamesLin Jul 11, 2016
488db47
Update GITHUB_RULES.md
Jul 11, 2016
f9629be
[ASMapNode] Defaulting userInteractionEnabled to YES.
george-gw Jul 11, 2016
41e2637
Removed debugging messages from ASMapNode's sample, they are no longe…
george-gw Jul 11, 2016
255e75a
Merge pull request #1893 from eJamesLin/fix_example_Multiplex_image_path
maicki Jul 11, 2016
137c706
Merge pull request #1892 from rcancro/finalLayoutableSetChildren
maicki Jul 11, 2016
93ee42d
Remove assert in visibleStateDidChange: in ASCellNode (#1899)
maicki Jul 12, 2016
7f47372
Change from MutexLocker / MutexUnlocker to lock() and unlock() direct…
maicki Jul 12, 2016
6b44b5a
[ASTableView] Add retainedLayer a la collection view (#1896)
Jul 12, 2016
396583d
[ASMapNode] Protected showAnnotationsOptions with a lock.
george-gw Jul 12, 2016
4b331be
Correctly compare and update title of ASButtonNode
nguyenhuy Jul 12, 2016
dc2255d
Fix setNeedsLayout triggered from subnode will not trigger relayout
maicki Jul 12, 2016
84029d1
Merge pull request #1902 from maicki/MSFixLayoutTriggerFromSubnodeNot…
maicki Jul 12, 2016
2e3da9b
Merge pull request #1903 from nguyenhuy/ASButtonNode_updateTitle
Jul 12, 2016
edb4e45
[ASRangeController] Update synchronously when possible
Adlai-Holler May 3, 2016
5d33ec1
Merge pull request #1619 from Adlai-Holler/RangeControllerSynchronous…
Jul 12, 2016
e40597e
Merge pull request #1792 from george-gw/prMapNode
Jul 12, 2016
2e19d11
Reduce block invocations, other small performance bumps
Jul 12, 2016
6aad142
[ASCollectionDataController] Some optimizations
Jul 12, 2016
9cd606d
Two more small performance wins
Jul 12, 2016
8eb25e7
[ASCollectionDataController] Use block-based enumeration with diction…
Jul 12, 2016
0a9b308
[_ASHierarchyChangeSet] Use std::unordered_map rather than dictionary
Jul 12, 2016
12697f1
AsyncDisplayKitOverview collection nodes size fix
Jul 13, 2016
464fa12
Merge pull request #1910 from feduza/overview-example-fix
Jul 13, 2016
e30c76c
Remove deprecated selected and highlighted methods (#1909)
maicki Jul 13, 2016
3b429f4
Fix building framework in Xcode
maicki Jul 13, 2016
beba131
Merge pull request #1914 from maicki/FixBuildingFrameworkXcode
Jul 13, 2016
793e151
Revert "Fix building framework in Xcode"
maicki Jul 13, 2016
6c82924
Merge pull request #1915 from maicki/RevertFixBuildingFrameworkXcode
maicki Jul 13, 2016
35c860c
Refactor usage of ASCollectionViewLayoutInspecting
maicki Jun 16, 2016
9fb3129
Add default ASCollectionViewLayoutInspecting for custom ASCollectionV…
maicki Jun 17, 2016
30bb2ee
Address comments from @levi
maicki Jun 24, 2016
d82a2e8
Move methods regarding supplementary nodes to optional in ASCollectio…
maicki Jun 27, 2016
8b3ec83
Small name changes
maicki Jul 8, 2016
ce98e56
Use getter of layout inspector to create it lazily and not have to cr…
maicki Jul 11, 2016
3591f7a
[ASViewController] Allow VC to conform to range updating protocol, lo…
Jul 14, 2016
65e194c
[Tests] Add failing tests for weird conformance issue
Jul 14, 2016
bd0254f
[ASRangeControllerUpdateRangeProtocol] BREAKING Remove +setRangeModeF…
Jul 14, 2016
b0a2ba0
[ASTableNode/ASCollectionNode] Make them conform directly to range up…
Jul 14, 2016
787fd8b
[ASViewController] Defer range update conformance check until the act…
Jul 14, 2016
09d1c06
Merge pull request #1755 from maicki/RefactorASCollectionViewLayoutIn…
maicki Jul 14, 2016
6e8772a
Fix sizing of root node in ASViewController for modal presentation an…
maicki Jul 14, 2016
cd46791
Move check for iOS 9 from an early return to an earlier check to prev…
maicki Jul 14, 2016
fd856fc
Merge pull request #1917 from maicki/MSFixLegacySizingASViewController
maicki Jul 14, 2016
92e16fb
Share ASDK's PINRemoteImage cache with default instance of PINRemoteI…
garrettmoon Jul 14, 2016
aaea4a4
Class was in wrong #ifdef, thank you @schneider!
garrettmoon Jul 14, 2016
f95790f
Merge pull request #1923 from garrettmoon/shareMemoryCache
maicki Jul 14, 2016
fe63b7b
Use fast enumeration in a couple places
Jul 14, 2016
bbc957b
Throw away all subcomponents of the text kit renderer if constraints …
maicki Jul 14, 2016
cac0cce
[ASLayoutTransition] Make findNodesInLayoutAtIndexesWithFilteredNodes…
Jul 14, 2016
705cc76
Fix failing ASTextNode tests
maicki Jul 15, 2016
a8c5ac1
[ASDisplayNode] Always layout nodes on a background thread (#1907)
maicki Jul 15, 2016
359785a
[ASDisplayNode] Add automatic measurement before layout (#1725)
maicki Jul 15, 2016
c403175
[ASTextNode] use accessor for `pointSizeScaleFactors`
rcancro Jul 15, 2016
013c163
Merge pull request #1924 from maicki/MSFixASTextNodeTruncationAgain
Jul 15, 2016
e7fc5a9
Merge pull request #1906 from facebook/AHReduceBlockInvocations
Jul 15, 2016
cc8e004
Merge pull request #1921 from facebook/AHRangeModeUpdatingIssues
Jul 15, 2016
729766a
Add convenience functions to create relative sizes with percentage
maicki Jul 15, 2016
eccd704
Merge pull request #1928 from maicki/MSAddRelativeSizePercentage
maicki Jul 15, 2016
4447ae4
Move ASPerformBlockOnBackgroundThread as it already calls the method …
maicki Jul 15, 2016
20a49f0
Comment adjustment for laying out nodes
maicki Jul 15, 2016
fcfce51
Grab propertyLock to get supportsRangeManagedInterfaceState and for a…
maicki Jul 15, 2016
9729b61
Add whitespace
maicki Jul 15, 2016
3237ccc
Merge pull request #1930 from maicki/MSSmallCodeImprovement
maicki Jul 15, 2016
bd907dc
added comment
rcancro Jul 15, 2016
3b09cbb
Merge pull request #1929 from rcancro/textScaleFactors
maicki Jul 15, 2016
dda7acc
[ASCollectionView] When resizing, invalidate after remeasuring all no…
Jul 15, 2016
abf8d5b
[Infer] change atomic properties to nonatomic (#1932)
Jul 16, 2016
4baf9bd
[Infer] Fix Infer errors/warnings (#1938)
Jul 16, 2016
3664ca6
[ASDisplayNode] Short circuit measure calls that have a zero-area con…
appleguy Jul 16, 2016
74bf376
[ASDisplayNode] Rename _propertyLock to __instanceLock__ to avoid sub…
appleguy Jul 16, 2016
8644c03
Revert "[ASDisplayNode] Short circuit measure calls that have a zero-…
appleguy Jul 16, 2016
6e573fb
Reset _calculatedSize if a new constrained size is set on the ASTextK…
maicki Jul 16, 2016
d4c5a09
[ASDisplayNode+AsyncDisplay.mm] Refactor display block creation metho…
appleguy Jul 16, 2016
fa34888
[ASDataController] Migrate to GCD queue to make debugging easier
Jul 18, 2016
50e8ad2
[ASTableView/ASCollectionView] Ignore bounds.origin when checking for…
Jul 18, 2016
f737d28
Merge pull request #1947 from facebook/AHFixZeroSizeLayout
Jul 18, 2016
46a911e
[ASDataController] Clean up by using a dispatch_group
Jul 18, 2016
1777dae
[ASDataController] Set context variable value
Jul 19, 2016
fceae5d
Merge pull request #1946 from facebook/AHDataControllerGCD
Jul 19, 2016
a455586
Re-enabling HLS video constructed from URL
Xinchi Jun 14, 2016
7237149
Merge branch 'patch-4' of https://github.com/Xinchi/AsyncDisplayKit i…
Jul 19, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AsyncDisplayKit/ASButtonNode.mm
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ - (void)updateTitle
newTitle = _normalAttributedTitle;
}

if ((_titleNode != nil || newTitle.length > 0) && newTitle != self.titleNode.attributedString) {
if ((_titleNode != nil || newTitle.length > 0) && [self.titleNode.attributedString isEqualToAttributedString:newTitle] == NO) {
_titleNode.attributedString = newTitle;
self.accessibilityLabel = _titleNode.accessibilityLabel;
[self setNeedsLayout];
Expand Down