This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASLayoutSpec] Remove use of dictionary to hold children #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Looks good, @rcancro. Curious of the use of a vector over a map? |
|
No real reason. @appleguy said that the NSDictionary I was using was showing up in profiling, so I had arrays on the brain. Though I do worry about returning |
Converted the backing store of children to a std::vector. Subclass now have defined indexes instead of string keys to add children.
|
LGTM! |
|
👍🏽 |
maicki
changed the title
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the backing store of children to a std::vector. Subclass now have defined indexes instead of string keys to add children.