This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[Accessibility / iOS 8] Fix 8.0 and 8.1-only, VoiceOver crash when clearing delegate / dataSource for Table or Collection #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@levi, @nguyenhuy, anyone else who could give this a review? Happy to merge as soon as one person gives a close analysis. |
appleguy
changed the title
|
@appleguy: LGTM |
|
@appleguy LGTM. Land away! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a delegate / dataSource get's set to nil in ASTableView or ASCollectionView on iOS 8.0 / 8.1 it triggers an accessibility call that the delegate / dataSource proxy is catching. The problem with that is that it goes into a loop as it tries to call
proxyTargetHasDeallocatedwhat could again trigger to set the delegate / dataSource to nil and the accessibility call is triggered again.