This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASCellNode] Remove check to fix layout issues #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des in an ASCollectionView when being resized after calling `setNeedsLayout()`
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Sep 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Slack (starting here: https://asyncdisplaykit.slack.com/archives/general/p1461252947000266) there can be layout issues with ASCellNodes in an ASCollectionView. The scenario uses a cell that loads an image from the network, and the size of the image is unknown, so a default aspect ratio is used for layout purposes. When the image loads, the cell is resized using
setNeedsLayout(). This can occasionally cause cells to overlap, or for there to be large gaps between cells. Removing the check forself.isNodeLoadedresolves the issue.