Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[AsyncDisplayKit Build / Cocoapods] Add Core subspec that excludes PINRemoteImage etc.#1522

Merged
appleguy merged 2 commits into
facebookarchive:masterfrom
HeEAaD:core-subspec
Apr 14, 2016
Merged

[AsyncDisplayKit Build / Cocoapods] Add Core subspec that excludes PINRemoteImage etc.#1522
appleguy merged 2 commits into
facebookarchive:masterfrom
HeEAaD:core-subspec

Conversation

@HeEAaD
Copy link
Copy Markdown

@HeEAaD HeEAaD commented Apr 12, 2016

Description

This pull request moves all mandatory files into its own Core subspec.

Resolved problem

Cocoapods that have AsyncDisplayKit as a dependency can not exclude PINRemoteImage.

Solution

Cocoapods are able to specify the Core subspec as a dependency:

spec.dependency 'AsyncDisplayKit/Core', '~> 1.9.7'

Podspec linter output

$ pod spec lint AsyncDisplayKit.podspec

 -> AsyncDisplayKit (1.9.7.2)

Analyzed 1 podspec.

AsyncDisplayKit.podspec passed validation.

@appleguy
Copy link
Copy Markdown
Contributor

appleguy commented Apr 13, 2016

@HeEAaD there are some issues with Travis, but this may be a real failure; it did pass tests but not building all the example apps with Travis.

https://travis-ci.org/facebook/AsyncDisplayKit/jobs/122629240

@HeEAaD
Copy link
Copy Markdown
Author

HeEAaD commented Apr 13, 2016

Excluded AsyncDisplayKit/Private/_AS-objc-internal.h for the Core because its part of ASDealloc2MainObject.

./build.sh examples should be green now.

garrettmoon
garrettmoon reviewed Apr 13, 2016
View reviewed changes
Comment thread AsyncDisplayKit.podspec Outdated
pin.dependency 'AsyncDisplayKit/Core'
end

# Include optional FLAnimatedImage module
Copy link
Copy Markdown
Contributor

@garrettmoon garrettmoon Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind changing this to PINRemoteImage in the comment?

@appleguy appleguy merged commit ba01104 into facebookarchive:master Apr 14, 2016
@appleguy appleguy changed the title Add Core subspec [AsyncDisplayKit Build / Cocoapods] Add Core subspec that excludes PINRemoteImage etc. Apr 14, 2016
@appleguy appleguy added this to the 1.9.8 milestone Apr 14, 2016
@HeEAaD HeEAaD deleted the core-subspec branch April 14, 2016 21:05
aimalygin pushed a commit to aimalygin/AsyncDisplayKit that referenced this pull request Sep 23, 2019
@maicki
Use flag for responder chain methods between view and node dispatching (
62e5a8e 
facebookarchive#1522)

* Use flag for responder chain methods between view and node dispatching

* Use bitfields
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Needs Unit Testing Refactoring

Projects

None yet

Milestone

1.9.8

Development

Successfully merging this pull request may close these issues.

4 participants

@HeEAaD @appleguy @garrettmoon @facebook-github-bot