This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[AsyncDisplayKit Build / Cocoapods] Add Core subspec that excludes PINRemoteImage etc. #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeEAaD there are some issues with Travis, but this may be a real failure; it did pass tests but not building all the example apps with Travis. https://travis-ci.org/facebook/AsyncDisplayKit/jobs/122629240 |
|
Excluded
|
| @@ -53,7 +55,7 @@ Pod::Spec.new do |spec| | |||
| spec.subspec 'PINRemoteImage' do |pin| | |||
| pin.xcconfig = { 'GCC_PREPROCESSOR_DEFINITIONS' => '$(inherited) PIN_REMOTE_IMAGE=1' } | |||
| pin.dependency 'PINRemoteImage/iOS', '>= 2.1.2' | |||
| pin.dependency 'AsyncDisplayKit/ASDealloc2MainObject' | |||
| pin.dependency 'AsyncDisplayKit/Core' | |||
| end | |||
|
|
|||
| # Include optional FLAnimatedImage module | |||
There was a problem hiding this comment.
Mind changing this to PINRemoteImage in the comment?
appleguy
changed the title
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Sep 23, 2019
facebookarchive#1522) * Use flag for responder chain methods between view and node dispatching * Use bitfields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request moves all mandatory files into its own
Coresubspec.Resolved problem
Cocoapods that have AsyncDisplayKit as a dependency can not exclude
PINRemoteImage.Solution
Cocoapods are able to specify the
Coresubspec as a dependency:Podspec linter output