Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[Documentation] Various header documentation corrections and refinements.#1340

Merged
appleguy merged 4 commits intofacebookarchive:masterfrom
ejensen:documentation-corrections
Mar 9, 2016
Merged

[Documentation] Various header documentation corrections and refinements.#1340
appleguy merged 4 commits intofacebookarchive:masterfrom
ejensen:documentation-corrections

Conversation

@ejensen
Copy link
Contributor

@ejensen ejensen commented Mar 8, 2016

No description provided.

@ejensen ejensen changed the title Documentation comment corrections [Documentation] Parameter documentation corrections Mar 8, 2016
@appleguy appleguy added this to the 1.9.7 milestone Mar 8, 2016
@param mask An ASControlNodeEvent mask.
@param block The block to be invoked for each ASControlNodeEvent included in mask.
@param anEvent An even that is included in mask.
@param anEvent An even that is included in mask.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems incorrect / revert indentation.

@appleguy
Copy link
Contributor

appleguy commented Mar 8, 2016

@ejensen this is very nice of you, thanks! Would love to merge, just making sure the indentations aren't errors.

@aaronschubert0
Copy link
Contributor

@ejensen I presume you found these through the latest Xcode 7.3 beta? There's also "errors" for depreciated methods that aren't addressed in this PR. Would be great to fix all in one shot.

@ejensen
Copy link
Contributor Author

ejensen commented Mar 8, 2016

The indentation was flattened. There were places in ASMultiplexImageNode that used the hierarchical indentation before this PR. They have also been flattened.

Those 2 deprecated ASImageCacheProtocol methods now have the deprecated attribute.

@appleguy appleguy changed the title [Documentation] Parameter documentation corrections [Documentation] Various header documentation corrections and refinements. Mar 9, 2016
@appleguy
Copy link
Contributor

appleguy commented Mar 9, 2016

@ejensen I love this kind of diff. Thanks a lot for caring about this stuff!

Feel free to submit a change anytime, even if for a minor or single-line issue. I would also love to hear from you by email if you have or have questions or feedback about the framework. (asyncdisplaykit@gmail.com)

appleguy added a commit that referenced this pull request Mar 9, 2016
[Documentation] Various header documentation corrections and refinements.
@appleguy appleguy merged commit de4e4db into facebookarchive:master Mar 9, 2016
@ejensen ejensen deleted the documentation-corrections branch March 9, 2016 17:57
fruitcoder pushed a commit to digitalegarage/AsyncDisplayKit that referenced this pull request Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants