[ASTextNode] Prompt creation of truncater object when the context object is accessed.

[yury]

See comment

Fixes #865.

attributedString on ASTextNode should be set after all truncationStrings...

[appleguy]

@yury what exactly is the dependency here? Why doesn't the truncater get accessed, e.g. [self truncater] get called, at a later point as soon as it is required? Thanks a lot for looking at this!

[yury]

@appleguy as my debugging shows, [self truncater] is called only to get visibleRange to detect links. And it is to late at that moment.

Truncated should be initialized ahead of size calculation so it can actually truncate string in it's initializer.
@tomizimobile patch here #1033 also init truncater ahead.

[yury]

Actual message text

hello
this is
very long
message here
and here

with maximumNumberOfLines = 4, truncationAttributedString = " ..." and additionalTruncationMessage = "read more"

Before fix

after

[appleguy]

@yury thank you for those additional details. It is still mysterious to me why this object has to be created ahead of time and I wonder if there is a later point than init where it can be created, as init may occur on the main thread, but none of our sizing calculations occur there. If you're able to share a test case, I can verify, but it's possible the perf impact of this is negligible with the current factoring of the code (it used to be measurable as suboptimal).

[appleguy]

Merging this for correctness now, optimization later with a test case. Please email me at asyncdisplaykit@gmail.com with any other thoughts! cc @tomizimobile

[tomizimobile]

@appleguy I've tried out master just now, and while the truncation string now appears, it seems that you can't actually interact with it. Using the workaround I talked about in #1033 still seems to work for me.
@yury Are you seeing this same behavior?

[yury]

@tomizimobile will check tomorrow.

[yury]

@appleguy, @tomizimobile confirming that textNodeTappedTruncationToken doesn't called.

And confirming, that @tomizimobile workaround fixes this.

@tomizimobile can you make PR?