Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Caching code seems entirely unused #7

Closed
toulouse opened this issue Jul 16, 2014 · 1 comment
Closed

Caching code seems entirely unused #7

toulouse opened this issue Jul 16, 2014 · 1 comment

Comments

@toulouse
Copy link
Contributor

git grep -i cache shows mentions of caching but no actual logic.

A quick sweep shows that the following is unused:

  • ASDisplayNode: NSArray *cachedNodes
  • ASDisplayNode: BOOL cacheNode
  • ASDisplayNode: ASDisplayNode *superCacheNode
  • ASImageCacheProtocol: Unimplemented and unused
@secretiverhyme
Copy link
Contributor

Thanks for the report! Some of these may be used in future by code that we haven't yet open-sourced. I've marked this as a blocker for the 1.0 release.

@secretiverhyme secretiverhyme self-assigned this Sep 20, 2014
nguyenhuy pushed a commit to nguyenhuy/AsyncDisplayKit that referenced this issue Apr 18, 2017
aimalygin pushed a commit to aimalygin/AsyncDisplayKit that referenced this issue Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants