[ASNetworkImageNode] Placeholder does not fade out for network images

[dohyeondk]

Talked with @appleguy with this issue on slack on Nov 5.

Reproduce

• examples_extra/Placeholders diff.txt
• Changed ASImageNode -> ASNetworkImageNode
• Loaded network image
• Removed ForwardWorkaround in SlowpokeImageNode

Expected

Placeholder image fade out with placeholderFadeDuration and placeholderFadeEnabled set.

Current

• This issue is not occurring 100% time. Refer to the gif image below: first attempt show animation properly, other attempt does not.
• with ForwardWorkaround and for duration over 0.1s, the issue is not occurring.

Affected Version (checked)

• 1.9.81
• 1.9.90
• 1.9.92
• 2.0-beta.1

[garrettmoon]

I'll try and take a look at this one.

[gkpetrov89]

@kimshako A quick workaround is to adopt the ASNetworkImageNodeDelegate and implement the imageNode:didLoad: method where you can add a CATransition to the node layer.

CATransition *transition = [CATransition animation];
[transition setDuration:0.25];
[transition setTimingFunction:[CAMediaTimingFunction functionWithName:kCAMediaTimingFunctionEaseInEaseOut]];
[transition setType:kCATransitionFade];
[[self layer] addAnimation:transition forKey:@"AsyncImageNodeDisplayTransition"];

[dohyeondk]

@EviluS Thank you for your workaround. I had been using similar approach using UIView.animate(), though, this solution looks better to me.

[appleguy]

We do need to fix this very soon, but can't squeeze it in for 2.0. Higher priority for 2.0.1.