MinGW Build Fixes #2685
MinGW Build Fixes #2685
Conversation
|
Hi @JPEWdev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Fixes building on MinGW by
1) Exporting the OS variable so that it is visible to sub-make
invocations
2) Fixing the extension handling so that make correctly identifies when
targets need to be rebuilt. Without the correct handling, make would
rebuild the executable targets when running `make install` because
it couldn't find them with the correct extension.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
|
Superseded by #2687 |
Fixes building on MinGW by
invocations
targets need to be rebuilt. Without the correct handling, make would
rebuild the executable targets when running
make installbecauseit couldn't find them with the correct extension.
Signed-off-by: Joshua Watt JPEWhacker@gmail.com