Fix justify content with min/max constraint parent #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lmxxf
reviewed
Nov 7, 2017
yoga/Yoga.c
Outdated
| paddingAndBorderAxisRow; | ||
| const float maxInnerWidth = | ||
| YGResolveValue(&node->style.maxDimensions[YGDimensionWidth], parentWidth) - marginAxisRow - | ||
| YGResolveValue(&node->style.maxDimensions[YGDimensionWidth], parentWidth) - | ||
| paddingAndBorderAxisRow; | ||
| const float minInnerHeight = | ||
| YGResolveValue(&node->style.minDimensions[YGDimensionHeight], parentHeight) - |
There was a problem hiding this comment.
It seems min/maxInnerHeight should be treated same as min/maxInnerWidth ?
There was a problem hiding this comment.
you're right, thansk. pushed an update.
fix constrained height
woehrl01
force-pushed
the
justifyContentMin
branch
from
c2b8cf0 to
60aae7a
Compare
|
Thanks, and sorry for the delay in reviewing! |
There was a problem hiding this comment.
@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 24, 2017
Summary: The min/max inner width shouldn't take the margins into account. Adds a test for both cases. Fixes #664 Closes facebook/yoga#665 Differential Revision: D6407982 Pulled By: emilsjolander fbshipit-source-id: ffa549a06f802263e3b8488e90756aa3f722d52d
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: The min/max inner width shouldn't take the margins into account. Adds a test for both cases. Fixes facebook#664 Closes facebook/yoga#665 Differential Revision: D6407982 Pulled By: emilsjolander fbshipit-source-id: ffa549a06f802263e3b8488e90756aa3f722d52d
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: The min/max inner width shouldn't take the margins into account. Adds a test for both cases. Fixes facebook#664 Closes facebook/yoga#665 Differential Revision: D6407982 Pulled By: emilsjolander fbshipit-source-id: ffa549a06f802263e3b8488e90756aa3f722d52d
vincentriemer
pushed a commit
to vincentriemer/yoga-dom
that referenced
this pull request
May 9, 2018
Summary: The min/max inner width shouldn't take the margins into account. Adds a test for both cases. Fixes #664 Closes facebook/yoga#665 Differential Revision: D6407982 Pulled By: emilsjolander fbshipit-source-id: ffa549a06f802263e3b8488e90756aa3f722d52d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min/max inner width shouldn't take the margins into account.
Adds a test for both cases.
Fixes #664