Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use static values for undefined and auto lengths #1734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use static values for undefined and auto lengths #1734

wants to merge 1 commit into from

Commits on Oct 30, 2024

  1. Use static values for undefined and auto lengths (facebook#1734) 

    Summary:
X-link: facebook/react-native#47305


X-link: facebook/litho#1030

Profiling in a test app with many undefined lengths shows this saves roughly 33% of time spent in Yoga.

## Changelog

[General][Fixed] Reduce amount of time spent in Yoga by reusing statically defined values in StyleLength::getLength()

Reviewed By: yungsters, mdvacca

Differential Revision: D65207753
    @rozele @facebook-github-bot
    rozele authored and facebook-github-bot committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6b1c14f View commit details
    Browse the repository at this point in the history