Java bindings for setAlwaysFormsContainingBlock #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D52608259 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 8, 2024
Summary: X-link: facebook/react-native#42192 tsia Differential Revision: D52608259
joevilches
force-pushed
the
export-D52608259
branch
from
b5fbdaf
to
eb66c0a
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/react-native#42192 tsia Reviewed By: NickGerleman Differential Revision: D52608259
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1540 tsia Reviewed By: NickGerleman Differential Revision: D52608259
|
This pull request was exported from Phabricator. Differential Revision: D52608259 |
Summary: X-link: facebook/react-native#42191 React native supports transforms and if a node has a transform it will [form a containing block for absolute descendants regardless of position type](https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#identifying_the_containing_block). So we need to pass that information into Yoga to ensure this happens. The verbiage for the field "alwaysFormsContainingBlock" is very specific. In a vacuum a node cannot simply "form a containing block". It only forms a containing block in reference to a different node. This can be illustrated in a scenario where we have a static node that is a flex container which has 1 absolute child and 1 relative child. This static node will form a containing block for the relative child but not the absolute one. We could just pass the information on rather something has a transform or not but Yoga is not supposed to know about transforms in general. As a result we have a notion of "always" forming a containing block. Since Yoga is a flexbox spec, non-absolute nodes' containing blocks will ways be their parent. If we add something like a transform to a node then that will also apply to absolute nodes - hence we can say the node will **always** form a CB, no matter who is the descendant. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52521160
Summary: X-link: facebook/react-native#42192 tsia Reviewed By: NickGerleman Differential Revision: D52608259
joevilches
force-pushed
the
export-D52608259
branch
from
eb66c0a
to
7dc21c6
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/react-native#42192 tsia Reviewed By: NickGerleman Differential Revision: D52608259
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1540 tsia Reviewed By: NickGerleman Differential Revision: D52608259
|
This pull request was exported from Phabricator. Differential Revision: D52608259 |
joevilches
force-pushed
the
export-D52608259
branch
from
7dc21c6
to
4e5dafd
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1540 tsia Reviewed By: NickGerleman Differential Revision: D52608259
|
This pull request was exported from Phabricator. Differential Revision: D52608259 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/react-native#42192 X-link: facebook/yoga#1540 tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52608259 fbshipit-source-id: 647ec4e2fe180ace8d6b641e17cd610fa53fe845
|
This pull request has been merged in 47e9f33. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: #42192 X-link: facebook/yoga#1540 tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52608259 fbshipit-source-id: 647ec4e2fe180ace8d6b641e17cd610fa53fe845
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42192 X-link: facebook/yoga#1540 tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52608259 fbshipit-source-id: 647ec4e2fe180ace8d6b641e17cd610fa53fe845
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
Summary: Pull Request resolved: facebook#42192 X-link: facebook/yoga#1540 tsia Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52608259 fbshipit-source-id: 647ec4e2fe180ace8d6b641e17cd610fa53fe845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: tsia
Differential Revision: D52608259