Remove NumericBitfield #1463
Closed
Remove NumericBitfield #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Differential Revision: D51159415 fbshipit-source-id: 886c90824339e46d114600174609b406cf11e006
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Differential Revision: D51159415 fbshipit-source-id: ca0639d47bc68f2d895e72aaaad1cbdb17294be2
NickGerleman
force-pushed
the
export-D51159415
branch
from
368bfc9
to
9fe977b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 176e35d93a98db772086a7dd2baf70bf23d91491
NickGerleman
force-pushed
the
export-D51159415
branch
from
9fe977b
to
559e5aa
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 836760e636b6506fd3f4319f9678eebd7d67fa88
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 651f1d5edb1db9d01ac1b4aefecc93ebcc25897e
NickGerleman
force-pushed
the
export-D51159415
branch
from
559e5aa
to
538c94c
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: f0dbd44335452e2876fbed1ac0f5033287aae03c
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 5daa0bca975fc8b61a20dfddbd817fd384d83921
NickGerleman
force-pushed
the
export-D51159415
branch
from
538c94c
to
ff07ab5
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: a1f2cd3cf99a8edfb6a35b5ff529feb6452696bf
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 772cade95e56d02aee58ef8c8f097aa9491eee75
NickGerleman
force-pushed
the
export-D51159415
branch
from
ff07ab5
to
03fc3fb
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 041e4eec0ac0c30b9e6c59ce1f4c374d9a0a5dac
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: cacb96034603aac489ef4816f0044430cec98845
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: d20b16efb69286d1e05f0c0b552c530c518500f0
NickGerleman
force-pushed
the
export-D51159415
branch
from
03fc3fb
to
d54536c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 21, 2023
Summary: X-link: facebook/react-native#41394 Pull Request resolved: facebook#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 76e6172c327db2bb519fcf4e46adc0f637ef2bd5
NickGerleman
force-pushed
the
export-D51159415
branch
from
d54536c
to
ad9f219
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41394 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
force-pushed
the
export-D51159415
branch
from
c35f204
to
de5f58f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41394 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/react-native#41394 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
force-pushed
the
export-D51159415
branch
2 times, most recently
from
b19b706
to
7218a79
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
NickGerleman
force-pushed
the
export-D51159415
branch
from
7218a79
to
87ba9a9
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41394 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
Summary: X-link: facebook/react-native#41389 Moves the last usages of `yoga::Style::Ref` to setters. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51154501
Summary: X-link: facebook/react-native#41393 Removes the last of the non setter-style style setters. Changelog: [Internal] Reviewed By: javache Differential Revision: D51155925
Summary: X-link: facebook/react-native#41394 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
NickGerleman
force-pushed
the
export-D51159415
branch
from
87ba9a9
to
8a452fe
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415
|
This pull request was exported from Phabricator. Differential Revision: D51159415 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 28, 2023
Summary: X-link: facebook/react-native#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 7842a8330eed6061b863de3f175c761dcf4aa2be
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 28, 2023
Summary: Pull Request resolved: #41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 7842a8330eed6061b863de3f175c761dcf4aa2be
|
This pull request has been merged in bb8fd59. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41394 X-link: facebook/yoga#1463 Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members. Reviewed By: joevilches Differential Revision: D51159415 fbshipit-source-id: 7842a8330eed6061b863de3f175c761dcf4aa2be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that are enums are unsigned, and we don't have BitfieldRef, we can convert the last remaining user of NumericBitfield to a plain old bitfield, for better readability (e.g. the default values), debugability, and less complexity. We also break a cycle which lets us properly group public vs private members.
Differential Revision: D51159415