Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of Gutters arrays and YGGutter as index #1406

Closed
wants to merge 1 commit into from
Closed

Remove usage of Gutters arrays and YGGutter as index #1406

wants to merge 1 commit into from

Commits on Oct 3, 2023

  1. Remove usage of Gutters arrays and YGGutter as index (facebook#1406) 

    Summary:
X-link: facebook/react-native#39597


Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying.

This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later.

Reviewed By: rshest

Differential Revision: D49530923
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    add28a3 View commit details
    Browse the repository at this point in the history