C++ style enums 3/N: ExperimentalFeature #1386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49269440 |
|
This pull request was exported from Phabricator. Differential Revision: D49269440 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39448 Pull Request resolved: facebook#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Differential Revision: D49269440 fbshipit-source-id: 9df185d769c296c3634929fefd30b59b83677517
NickGerleman
force-pushed
the
export-D49269440
branch
from
96c5348
to
79cc76b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39448 X-link: facebook/yoga#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Differential Revision: D49269440 fbshipit-source-id: a24bec805d3ac4126361046b4d838d4c42e294e8
|
This pull request was exported from Phabricator. Differential Revision: D49269440 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39448 Pull Request resolved: facebook#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Differential Revision: D49269440 fbshipit-source-id: a44dc960061bd2c3552a23cc78e19d92a2884d99
NickGerleman
force-pushed
the
export-D49269440
branch
from
79cc76b
to
a07cae4
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39448 X-link: facebook/yoga#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Differential Revision: D49269440 fbshipit-source-id: c21b4d443e8e7a15d812607fa55d05de174179a8
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: a30fbc1ac4b8fa2683a658c7ac7911e640153ee6
Differential Revision: D49269117 fbshipit-source-id: 891ca742e64366a2eabae04f9047b00e7d095b9a
Summary: X-link: facebook/react-native#39448 Pull Request resolved: facebook#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Reviewed By: rozele Differential Revision: D49269440 fbshipit-source-id: 112f4d3816b52f133d5ce176f0dbda468deb5c08
|
This pull request was exported from Phabricator. Differential Revision: D49269440 |
NickGerleman
force-pushed
the
export-D49269440
branch
from
a07cae4
to
20e6dd5
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39448 X-link: facebook/yoga#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Reviewed By: rozele Differential Revision: D49269440 fbshipit-source-id: 6e1141df05a77e1b1937d6b47f4d20d7f3c8b970
|
This pull request has been merged in 42e1f2c. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #39448 X-link: facebook/yoga#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Reviewed By: rozele Differential Revision: D49269440 fbshipit-source-id: 0fcb4f380e214a6aadcac457df5a989789bb05d2
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39448 X-link: facebook/yoga#1386 This converts usages of YGExperimentalFeature to ExperimentalFeature Reviewed By: rozele Differential Revision: D49269440 fbshipit-source-id: 0fcb4f380e214a6aadcac457df5a989789bb05d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGExperimentalFeature to ExperimentalFeature
Differential Revision: D49269440