Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JNI Binding usage of layoutContext #1377

Closed
wants to merge 2 commits into from
Closed

Remove JNI Binding usage of layoutContext #1377

wants to merge 2 commits into from

Commits on Sep 13, 2023

  1. Extract isBaselineLayout() 

    Summary: Moves `isBaselineLayout` out of `CalculateLayout` into `Baseline.h`. This function is called by flex line justification code, which I have been looking at extracting.

Differential Revision: D49177937

fbshipit-source-id: 7ae3e8c9bb5ce82fb91626f7ab6c8886ef8d22a8
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fd0707e View commit details
    Browse the repository at this point in the history

  2. Remove JNI Binding usage of layoutContext (facebook#1377) 

    Summary:
X-link: facebook/react-native#39402

Pull Request resolved: facebook#1377

To avoid keeping a per-node mapping on native Yoga nodes to Java nodes, a per-layout context was added, to be able to pass information from the start of the layout, to measure functions, log functions, etc.

The way this was done was super invasive, and added quite a few private APIs used only by the JNI functions.

This change removes the context-using functions from the JNI bindings in favor of it managing its own context. Next diff removes all the cruft.

Reviewed By: javache

Differential Revision: D49179243

fbshipit-source-id: c838dce0a4356eecce243db22b4050793c4920e4
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    02aafae View commit details
    Browse the repository at this point in the history