Cleanup YGNode for explicit per-node config #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45133644 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45133644 |
NickGerleman
force-pushed
the
export-D45133644
branch
from
52df722
to
9c2c4dd
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/litho#941 X-link: facebook/yoga#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: 46b2bf1dea86e10ea96a51e1501e95b945a3c271
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/react-native#36989 Pull Request resolved: facebook#941 X-link: facebook/yoga#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: 3455739e33be3d81cb6e64ca885e9e5695391039
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#36989 X-link: facebook/litho#941 X-link: facebook/yoga#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: 4fda35f098748cea0003572dd3fc254844e1d18d
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/react-native#36989 X-link: facebook/litho#941 Pull Request resolved: facebook#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: 625b9b5a721a2fee10c3a637779b01208b300e86
NickGerleman
force-pushed
the
export-D45133644
branch
from
9c2c4dd
to
db16915
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45133644 |
Summary: X-link: facebook/react-native#36989 X-link: facebook/litho#941 Pull Request resolved: facebook#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: 4317eefdd323cfa2fc84d56954bd35254e0bf40d
NickGerleman
force-pushed
the
export-D45133644
branch
from
db16915
to
0471b65
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45133644 |
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/react-native#36989 Pull Request resolved: facebook#941 X-link: facebook/yoga#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: f5f4b526660faaca17bd9d8579d2c8bfb366b141
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#36989 X-link: facebook/litho#941 X-link: facebook/yoga#1249 Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node. We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default). Removes a peculiar constructor which was added to avoid config setting. Changelog: [Internal] Reviewed By: rshest Differential Revision: D45133644 fbshipit-source-id: f22565a348a5a479bf18b53f0f9d820f905c054c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleans up some of the changes to UseWebDefaults that were made in the interest of moving it outside of YGConfig. It still exists in YGConfig, but also exists on the node.
We also assert on null config, or when someone tries to change UseWebDefaults after creating a node (since right now YGStyle does not know the difference between unset vs set explicitly to what would normally be default).
Removes a peculiar constructor which was added to avoid config setting.
Differential Revision: D45133644