Remove yoga/internal/experiments #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These files are remnants of experimentation functions from D16687367 (facebook@dcfdb95). They do not seem to be included anywhere anymore, and we already have a YGExperimentalFeature setter in config we can use in the more common case. Changelog: [Internal] Differential Revision: D42241980 fbshipit-source-id: b5c6e8337313789e9c988c54a99bfbad2b840520
|
This pull request was exported from Phabricator. Differential Revision: D42241980 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 28, 2022
Summary: X-link: facebook/yoga#1195 These files are remnants of experimentation functions from D16687367 (c9b757f). They do not seem to be included anywhere anymore, and we already have a YGExperimentalFeature setter in config we can use in the more common case. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D42241980 fbshipit-source-id: 482984b9a619dba8042e9166aee02a5e75e761ee
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 28, 2022
Summary: X-link: facebook/yoga#1195 These files are remnants of experimentation functions from D16687367 (e084e59). They do not seem to be included anywhere anymore, and we already have a YGExperimentalFeature setter in config we can use in the more common case. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D42241980 fbshipit-source-id: 482984b9a619dba8042e9166aee02a5e75e761ee
|
This pull request has been merged in 287c48f. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 29, 2022
Summary: [Changelog][Internal] This appears to be a regression from facebook/yoga#1195 The `yoga/internal/experiments.cpp` was removed, but the corresponding Pod cache wasn't updated, which made the RNTester iOS to start fail. Reviewed By: christophpurrer Differential Revision: D42268322 fbshipit-source-id: 8db1118787ed41cde10babe6845f6d05a8f86bc2
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: X-link: facebook/yoga#1195 These files are remnants of experimentation functions from D16687367 (facebook@c9b757f). They do not seem to be included anywhere anymore, and we already have a YGExperimentalFeature setter in config we can use in the more common case. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D42241980 fbshipit-source-id: 482984b9a619dba8042e9166aee02a5e75e761ee
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: [Changelog][Internal] This appears to be a regression from facebook/yoga#1195 The `yoga/internal/experiments.cpp` was removed, but the corresponding Pod cache wasn't updated, which made the RNTester iOS to start fail. Reviewed By: christophpurrer Differential Revision: D42268322 fbshipit-source-id: 8db1118787ed41cde10babe6845f6d05a8f86bc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These files are remnants of experimentation functions from D16687367 (dcfdb95). They do not seem to be included anywhere anymore, and we already have a YGExperimentalFeature setter in config we can use in the more common case.
Changelog:
[Internal]
Differential Revision: D42241980