Skip to content

Document all Errors #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevinlewi merged 2 commits into from
Jan 25, 2022
Merged

Document all Errors #55

kevinlewi merged 2 commits into from
Jan 25, 2022

Conversation

@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jan 22, 2022

Basically add clippy::missing_errors_doc. Re-introduced InternalError to return something from hash_to_curve and hash_to_scalar that is actually not an error returned by the public API.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2022
This was referenced Jan 23, 2022
Merged
Closed
kevinlewi
kevinlewi approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@kevinlewi kevinlewi merged commit b01b8ed into facebook:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxpedda @kevinlewi @facebook-github-bot