chore: update more dependencies #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Open
kevinlewi
requested changes
Jan 23, 2026
Contributor
kevinlewi
left a comment
kevinlewi
left a comment
There was a problem hiding this comment.
Apologies for the delays in reviewing this!
Mostly looks good, but sending back to changes to eliminate the panic in random_scalar.
src/group/ristretto.rs
Outdated
| let mut scalar_bytes = [0u8; 32]; | ||
| rng.fill_bytes(&mut scalar_bytes); | ||
| rng.try_fill_bytes(&mut scalar_bytes) | ||
| .expect("RNG failure while filling scalar bytes"); |
Contributor
There was a problem hiding this comment.
I think we should avoid adding this panic here and instead change the random_scalar API to return a Result.
Comment on lines
+128
to
+129
| /// Adapter allowing `rand_core 0.9` RNGs to satisfy the `elliptic_curve` 0.13 | ||
| /// requirement for `rand_core 0.6` traits. |
Contributor
There was a problem hiding this comment.
Mainly a note to self when merging: we should add a tracking issue to remove this once we upgrade to the elliptic_curve version that uses rand_core 0.9
kevinlewi
approved these changes
Jan 25, 2026
Contributor
kevinlewi
left a comment
kevinlewi
left a comment
There was a problem hiding this comment.
This looks great. Thank you for making the changes! Merging...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the remaining dependencies and introduces a compatibility layer for
elliptic_curve.